feat: Add lua-language-server to CI #2611
Conversation
- Implement lua-language-server linter in pre-commit - Install via Nix due to lack of Ubuntu package - Apply patch for --check CLI bug using Nix overlay - Centralize linting config for VSCode, pre-commit, and CI Fixes cursorless-dev#2576
|
I wonder if we want to do this in pre-commit or as part of test. This feels like running tsc, which we do as part of our test CI step. I'm not in love with needing nix set up in order for pre-commit to work locally, so doing it as part of test makes it easier to just be CI-only / manually triggered locally |
|
Ok. I moved it into test.yml. I went the route of having another combined action again so we don't have to litter multiple entries with 'if linux'. Didn't manually test these new changes yet, so will see how the CI goes. |
|
Any idea why the 'ubuntu-latest, stable' CI test would've skipped here? That's the only one that will run the new lua test and was running before, so seems a bit weird... but details don't show anything. I don't seem to be able to force re-run it |
|
Hmm strange. Maybe try pushing an empty commit? |
fidgetingbits
changed the title
Fixes #2576
Checklist