Skip to content

neovim: add lua language server lint checks to CI #2576

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
fidgetingbits opened this issue Jul 26, 2024 · 1 comment · Fixed by #2611
Closed

neovim: add lua language server lint checks to CI #2576

fidgetingbits opened this issue Jul 26, 2024 · 1 comment · Fixed by #2611
Assignees
@fidgetingbits
Labels
app-neovim Issues related to neovim support

Comments

@fidgetingbits
Copy link
Collaborator

Atm warnings from vscode triggered by sumneko.lua plugin (using lua language server) don't fire in CI. This should ideally added via .pre-commit so people that run that locally can also see the errors in advance.
@fidgetingbits fidgetingbits added the app-neovim Issues related to neovim support label Jul 26, 2024
@pokey
Copy link
Member

pokey commented Jul 26, 2024

we would also ideally find a way to have a single source of truth for the lua language server config. Today it's all in .vscode/settings.json, which won't be read by CI

@fidgetingbits fidgetingbits self-assigned this Jul 29, 2024
fidgetingbits added a commit to fidgetingbits/cursorless that referenced this issue Jul 30, 2024
@fidgetingbits
feat: Add lua language server to pre-commit
5b1abfc 
Fixes cursorless-dev#2576. Adds lua-language-server linter to pre-commit. There is no
existing pre-commit hook, and also no Ubuntu package for this linter.
I install it using nix package manager, as nixpkgs is one of the only
places with a package. However, there is also a recent bug that prevents
--check invocation of the cli. I have patched this in the
lua-language-server using a nix overlay, until the PR is merged.

This also moves the linting configuration to a single source of true,
that vscode, pre-commit, CI can all use.
fidgetingbits added a commit to fidgetingbits/cursorless that referenced this issue Jul 30, 2024
@fidgetingbits
feat: Add lua-language-server to pre-commit hooks
8ea5326 
- Implement lua-language-server linter in pre-commit
- Install via Nix due to lack of Ubuntu package
- Apply patch for --check CLI bug using Nix overlay
- Centralize linting config for VSCode, pre-commit, and CI

Fixes cursorless-dev#2576
fidgetingbits added a commit to fidgetingbits/cursorless that referenced this issue Jul 31, 2024
@fidgetingbits
feat: Add lua-language-server to pre-commit hooks
edf5110 
- Implement lua-language-server linter in pre-commit
- Install via Nix due to lack of Ubuntu package
- Apply patch for --check CLI bug using Nix overlay
- Centralize linting config for VSCode, pre-commit, and CI

Fixes cursorless-dev#2576
@fidgetingbits fidgetingbits mentioned this issue Jul 31, 2024
Merged
3 tasks
github-merge-queue bot pushed a commit that referenced this issue Aug 1, 2024
@fidgetingbits @pokey
feat: Add lua-language-server to CI (#2611)
6d6addc 
- Implement lua-language-server linter in pre-commit
- Install via Nix due to lack of Ubuntu package
- Apply patch for --check CLI bug using Nix overlay
- Centralize linting config for VSCode, pre-commit, and CI

Fixes #2576



## Checklist

- [ ] I have added
[tests](https://www.cursorless.org/docs/contributing/test-case-recorder/)
- [ ] I have updated the
[docs](https://github.com/cursorless-dev/cursorless/tree/main/docs) and
[cheatsheet](https://github.com/cursorless-dev/cursorless/tree/main/cursorless-talon/src/cheatsheet)
- [ ] I have not broken the cheatsheet

---------

Co-authored-by: Pokey Rule <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fidgetingbits fidgetingbits

Labels
app-neovim Issues related to neovim support
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: Add lua-language-server to CI fidgetingbits/cursorless
2 participants
@pokey @fidgetingbits