Feature/get rid off boost dependency #136
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Liastre
force-pushed
the
feature/get-rid-off-boost-dependency
branch
from
416eaab to
ab5864a
Compare
|
Can you take a look at these conflicts, following the merge of #135? |
# Conflicts: # src/detail/uri_normalize.cpp # src/detail/uri_resolve.cpp
|
@glynos Thank you for a quick response. Must be fine now. Is there any particular reason why you do not maintain this uri implementation anymore? |
|
I don't maintain it because I want to spend my time on the WhatWG spec implementation (i.e. Skyr URL). There are a lot of flaws with the original (the spec and my implementation). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
3 additional commits to eliminate boost dependency, depends on my previous pull request