Feature/project update and refactor #135
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello, thanks for the PRs! What is the motivation for these changes? I am not normally maintaining this library because there is another that supersedes it: https://github.com/cpp-netlib/url. Are you already aware of that? |
|
Hey @glynos! Yeah, I'm aware of url library, thanks. We are using your uri library in our network solution, that's why I'm pushing those changes, to eliminate current differences and continue to contribute. As I know url is subset of uri, and url implementation is not what I'm actually looking for. |
|
The Skyr URL library is not just a subset of the URI, it implements a different specification. However, if this library works for you, I'm happy to integrate. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bunch of minor fixes for latest gcc compiler and codestyle. If codestyle changes is too complex (there only last two commits), I can rollback them, just let me know.