Add Google component filters for administrative areas, postal codes and countries #60
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ah - I am using a C# 6 feature, string interpolation. Let me fix. |
|
Thanks for this! I just updated the build server by the way to not freak out on C# 6 features. Before I merge, can you fix the formatting of the files? It is hard to read the diff since it looks like all the tabs have been converted to spaces. |
added 2 commits
September 24, 2016 12:48
|
Weird, I hadn't altered the formatting at all... My copy of VS must be doing something funky. I actually had to grab your raw files from source, open them in np++ and paste in my changes to fix the formatting. Hopefully all looks good now. |
Convert formatting to tabs instead of spaces
|
Awesome! Thanks again! |
adamhathcock
added a commit
to adamhathcock/Geocoding.net
that referenced
this pull request
Dec 13, 2016
* master: Don't include test project in ilmerged output Register google as default geocoder for example app Update .gitignore for VS 2015 Updating readme mapquest issues Upgrade Geocoding.Net in Example.sln. Can't reproduce chadly#45 and chadly#48. They are already fixed by commit ecc8cf6 Split tests for special characters and Street intersections (by ampersand) Test MapQuest Commercial API Implemented Google Geocoding channel feature (chadly#63) Bump version Add Google component filters for administrative areas, postal codes and countries (chadly#60) Adding Mixed SideOfStreet to MapQuest Bump minor version ahead of release Fixing space formatting Minor change Added place_id to GoogleAddress (chadly#52) update example output to match current return (chadly#54) # Conflicts: # Google/Google.csproj # Tests/MapQuestBatchGeocoderTest.cs # geocoding.nuspec # src/Geocoding.Google/GoogleGeocoder.cs # teamcity.targets # test/Geocoding.Tests/GoogleGeocoderTest.cs # test/Geocoding.Tests/MapQuestGeocoderTest.cs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added some functionality and tests for Google Component Filters.
I've added this because we have a scenario here where we only want to geocode within the UK.
I didn't bother with Route, given that this allows you to geocode without an address, which is required in this implementation.
I also haven't implemented Locality, as I couldn't find a use-case and didn't want to commit untested code.