Skip to content

Added place_id to GoogleAddress #52

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 6, 2016
Merged

Added place_id to GoogleAddress #52

merged 1 commit into from
Aug 6, 2016

Conversation

jaxuk
Copy link
Contributor

@jaxuk jaxuk commented May 18, 2016

I need the place_id from Google Addresses to easily link data, so I've added it in - I'm sure it'll be useful to others too.

@chadly chadly merged commit a669504 into chadly:master Aug 6, 2016
@chadly
Copy link
Owner

chadly commented Aug 6, 2016

Thanks!

@jaxuk
Copy link
Contributor Author

jaxuk commented Aug 7, 2016

No problem. Any idea when a build including this will get released? I had
issues trying to build the source.

On 6 Aug 2016 17:23, "Chad Lee" [email protected] wrote:

Thanks!


You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#52 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABc05YJSqqpUhkkxltFCTKLLJjQv8J8oks5qdLUIgaJpZM4IhRYx
.

@vladimirlapacek
Copy link

I would also appreciate having access to place_id, so a new NuGet build would be great. I may be missing something, but the above change does not seem to include a public getter for the place_id field. How are you getting it in your code?

Thanks.

@chadly
Copy link
Owner

chadly commented Sep 20, 2016

See #55

@vladimirlapacek
Copy link

OK, I see what happened. Can I help with sorting out the spacing problem? Would that speed up the change adoption in master and creating a new NuGet eventually?

@chadly
Copy link
Owner

chadly commented Sep 20, 2016

sure, PRs are always welcome

adamhathcock added a commit to adamhathcock/Geocoding.net that referenced this pull request Dec 13, 2016
* master:
  Don't include test project in ilmerged output
  Register google as default geocoder for example app
  Update .gitignore for VS 2015
  Updating readme mapquest issues
  Upgrade Geocoding.Net in Example.sln. Can't reproduce chadly#45 and chadly#48. They are already fixed by commit ecc8cf6
  Split tests for special characters and Street intersections (by ampersand)
  Test MapQuest Commercial API
  Implemented Google Geocoding channel feature (chadly#63)
  Bump version
  Add Google component filters for administrative areas, postal codes and countries (chadly#60)
  Adding Mixed SideOfStreet to MapQuest
  Bump minor version ahead of release
  Fixing space formatting
  Minor change
  Added place_id to GoogleAddress (chadly#52)
  update example output to match current return (chadly#54)

# Conflicts:
#	Google/Google.csproj
#	Tests/MapQuestBatchGeocoderTest.cs
#	geocoding.nuspec
#	src/Geocoding.Google/GoogleGeocoder.cs
#	teamcity.targets
#	test/Geocoding.Tests/GoogleGeocoderTest.cs
#	test/Geocoding.Tests/MapQuestGeocoderTest.cs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants