Rework CI #146
Merged
Rework CI #146
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simPod
force-pushed
the
fix-test
branch
2 times, most recently
from
d2ca412 to
c8c713c
Compare
simPod
force-pushed
the
fix-test
branch
27 times, most recently
from
69587ab to
2d5095a
Compare
- Use ramsey/composer-install action - Drop testing on multiple OSes as it's not relevant - Move timezone setting to bootstrap file - Run standalone PHPStan and Code Style checks - Bump justinrainbow/json-schema to v5.2 as it supports PHP 8.0 - Conflict with symfony/yaml `3.4.0 - 3.4.4 || 4.0.0 - 4.4.17 || 5.0.0 - 5.1.9 || 5.2.0` in order to prevent installing broken versions (especially this issue symfony/symfony#39521)
Closed
|
Thanks for your work on this one, I have one thing to discuss:
Multiple OS as relevant to make sure loading of external files from references works. There were some bugs about this on windows systems. That said, I'd like to keep testing on windows and mac, at least a combination of latest php and dependencies to make sure it works on these systems. |
simPod
force-pushed
the
fix-test
branch
2 times, most recently
from
fb9199e to
9050b93
Compare
|
@cebe we're running macos and windows now. Would it suffice like this? |
simPod
force-pushed
the
fix-test
branch
8 times, most recently
from
6f23a0d to
f23a106
Compare
|
It indeed shows a failure https://github.com/cebe/php-openapi/runs/4693855168?check_suite_focus=true |
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use ramsey/composer-install action
Drop testing on multiple OSes as it's not relevantMove timezone setting to bootstrap file
Run standalone PHPStan and Code Style checks
Bump justinrainbow/json-schema to v5.2 as it supports PHP 8.0
Conflict with symfony/yaml
3.4.0 - 3.4.4 || 4.0.0 - 4.4.17 || 5.0.0 - 5.1.9 || 5.2.0in order to prevent installing broken versions (especially this issue [Yaml] Regression 4.4.17 error loading YAML files with strings that have trailing whitespace symfony/symfony#39521)Run speccy through yarn
I'don't know windows and not sure how to force it to understand
composer require symfony/yaml:"^5"