Skip to content

Add symfony/yaml 6.0.0 support #134

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Add symfony/yaml 6.0.0 support #134

wants to merge 1 commit into from

Conversation

the-csaba
Copy link
Contributor

Symfony 6 released on November 29, 2021 .

Also, updated Github Action config to include 6, ans use the latest 5.x version

@cebe cebe added this to the 1.6.0 milestone Dec 21, 2021
@cebe
Copy link
Owner

cebe commented Dec 21, 2021

[InvalidArgumentException]
Package symfony/yaml at version 6.0.0 has requirements incompatible with your PHP version, PHP extensions and Composer version:
- symfony/yaml v6.0.0 requires php >=8.0.2 which does not match your installed version 7.3.33.

need to add combinations with symfony 6 and php versions < 8 to the exclude section.

@simPod
Copy link
Contributor

simPod commented Dec 29, 2021

@cebe there's alternative to excluding in #146

Use the version 6.0 in GH Action too
@the-csaba
Copy link
Contributor Author

the-csaba commented Dec 31, 2021

@cebe, GH Actions in our fork looks good: https://github.com/OM4/php-openapi/actions/runs/1639869647
Failed from #123 are also fixed

I am happy to update this or my other pull (#123) after you merge one of them. to avoid merge conflict

@racastellanosm
Copy link

Anyone knows when this PR will be merged? 🙏 (I need it for my project in SF 6) Thanks so much.

@bambamboole
Copy link

I would appreciate if this gets merged, since I can't use it as well because of symfony 6

@geekishmatt
Copy link

It would be really awesome if this gets merged otherwise I am not able to update few projects of mine to SF6

@victormln
Copy link

Same here! Waiting to be merged...

@the-csaba
Copy link
Contributor Author

Hi guys, if you need Symfony 6 or PHP 8.1 support right now, we are managing a fork that you can use, which contains changes from #146 and this pull: https://github.com/OM4/php-openapi

Just add the following to the repositories section in your composer.json file:

{
  "repositories": [
    {
      "type": "package",
      "package": {
        "name": "cebe/php-openapi",
        "version": "1.5.3",
        "source": {
          "url": "https://github.com/OM4/php-openapi",
          "type": "git",
          "reference": "428e95d9b0f9f3c8f4a0018cb9690edbc5a3ed6e"
        }
      }
    }
  ]
}

Let me know if you have any problems.

@simPod
Copy link
Contributor

simPod commented Jan 31, 2022

I'm going with

{
    "repositories": [
        {
            "type": "vcs",
            "url": "https://github.com/simPod/php-openapi"
        }
    ]
}

composer require cebe/php-openapi:"dev-master as 1.6.0"

@garethellis36
Copy link

Unfortunately I'm using another library that has a dependency on this one, so I can't use the forked version instead.

@simPod
Copy link
Contributor

simPod commented Feb 8, 2022

@garethellis36 with those "repositories" overrides mentioned above you can.

@cebe cebe mentioned this pull request Feb 9, 2022
@cebe cebe closed this in #151 Feb 9, 2022
@cebe
Copy link
Owner

cebe commented Feb 9, 2022

Thanks for you contribution. Due to merge conflict with master, I applied similar changes in #151, Symfony 6 is now supported in the upcoming release 1.6.0.

@the-csaba the-csaba deleted the symfony-6-compatibility branch February 9, 2022 21:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants