Plane mesh primitive does not have number of subdivisions as a parameter #191
Labels
A-Rendering
Drawing game state to the screen
C-Feature
A new feature, making something new possible
D-Trivial
Nice and easy! A great choice to get started with Bevy
Comments
karroffel
added
C-Feature
|
Discussion on Discord explaining some context on why we might want this feature. |
mockersf
added
the
D-Trivial
myreprise1
pushed a commit
to myreprise1/bevy
that referenced
this issue
Feb 14, 2023
# Objective There was issue bevyengine#191 requesting subdivisions on the shape::Plane. I also could have used this recently. I then write the solution. Fixes bevyengine#191 ## Solution I changed the shape::Plane to include subdivisions field and the code to create the subdivisions. I don't know how people are counting subdivisions so as I put in the doc comments 0 subdivisions results in the original geometry of the Plane. Greater then 0 results in the number of lines dividing the plane. I didn't know if it would be better to create a new struct that implemented this feature, say SubdivisionPlane or change Plane. I decided on changing Plane as that was what the original issue was. It would be trivial to alter this to use another struct instead of altering Plane. The issues of migration, although small, would be eliminated if a new struct was implemented. ## Changelog ### Added Added subdivisions field to shape::Plane ## Migration Guide All the examples needed to be updated to initalize the subdivisions field. Also there were two tests in tests/window that need to be updated. A user would have to update all their uses of shape::Plane to initalize the subdivisions field.
myreprise1
pushed a commit
to myreprise1/bevy
that referenced
this issue
Feb 15, 2023
# Objective There was issue bevyengine#191 requesting subdivisions on the shape::Plane. I also could have used this recently. I then write the solution. Fixes bevyengine#191 ## Solution I changed the shape::Plane to include subdivisions field and the code to create the subdivisions. I don't know how people are counting subdivisions so as I put in the doc comments 0 subdivisions results in the original geometry of the Plane. Greater then 0 results in the number of lines dividing the plane. I didn't know if it would be better to create a new struct that implemented this feature, say SubdivisionPlane or change Plane. I decided on changing Plane as that was what the original issue was. It would be trivial to alter this to use another struct instead of altering Plane. The issues of migration, although small, would be eliminated if a new struct was implemented. ## Changelog ### Added Added subdivisions field to shape::Plane ## Migration Guide All the examples needed to be updated to initalize the subdivisions field. Also there were two tests in tests/window that need to be updated. A user would have to update all their uses of shape::Plane to initalize the subdivisions field.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I'm going to try to work on this now
The text was updated successfully, but these errors were encountered: