Skip to content

fix(event_source): kinesis subsequenceNumber str type to int #3275

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 31, 2023
Merged

fix(event_source): kinesis subsequenceNumber str type to int #3275

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
beddb7a
change subsequenceNumber from str to int
roger-zhangg Oct 30, 2023
4a643d9
Merge branch 'develop' into firehoseSequenceFix
leandrodamascena Oct 31, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion aws_lambda_powertools/utilities/data_classes/kinesis_firehose_event.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -201,7 +201,7 @@ def sequence_number(self) -> str:
return self._metadata["sequenceNumber"]

@property
def subsequence_number(self) -> str:
def subsequence_number(self) -> int:
"""Kinesis stream sub-sequence number; present only when Kinesis Stream is source

Note: this will only be present for Kinesis streams using record aggregation
Expand Down
2 changes: 1 addition & 1 deletion aws_lambda_powertools/utilities/parser/models/kinesis_firehose.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ class KinesisFirehoseRecordMetadata(BaseModel):
partitionKey: str
approximateArrivalTimestamp: PositiveInt
sequenceNumber: str
subsequenceNumber: str
subsequenceNumber: int


class KinesisFirehoseRecord(BaseModel):
Expand Down
4 changes: 2 additions & 2 deletions tests/events/kinesisFirehoseKinesisEvent.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@
"partitionKey": "4d1ad2b9-24f8-4b9d-a088-76e9947c317a",
"approximateArrivalTimestamp": 1664028820148,
"sequenceNumber": "49546986683135544286507457936321625675700192471156785154",
"subsequenceNumber": ""
"subsequenceNumber": 0
}
},
{
Expand All @@ -25,7 +25,7 @@
"partitionKey": "4d1ad2b9-24f8-4b9d-a088-76e9947c318a",
"approximateArrivalTimestamp": 1664028793294,
"sequenceNumber": "49546986683135544286507457936321625675700192471156785155",
"subsequenceNumber": ""
"subsequenceNumber": 0
}
}
]
Expand Down
4 changes: 2 additions & 2 deletions tests/unit/parser/test_kinesis_firehose.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,7 @@ def test_firehose_trigger_event_kinesis_no_envelope():

metadata_01: KinesisFirehoseRecordMetadata = record_01.kinesisRecordMetadata
assert metadata_01.partitionKey == "4d1ad2b9-24f8-4b9d-a088-76e9947c317a"
assert metadata_01.subsequenceNumber == ""
assert metadata_01.subsequenceNumber == 0
assert metadata_01.shardId == "shardId-000000000000"
assert metadata_01.approximateArrivalTimestamp == 1664028820148
assert metadata_01.sequenceNumber == "49546986683135544286507457936321625675700192471156785154"
Expand All @@ -74,7 +74,7 @@ def test_firehose_trigger_event_kinesis_no_envelope():

metadata_02: KinesisFirehoseRecordMetadata = record_02.kinesisRecordMetadata
assert metadata_02.partitionKey == "4d1ad2b9-24f8-4b9d-a088-76e9947c318a"
assert metadata_02.subsequenceNumber == ""
assert metadata_02.subsequenceNumber == 0
assert metadata_02.shardId == "shardId-000000000001"
assert metadata_02.approximateArrivalTimestamp == 1664028793294
assert metadata_02.sequenceNumber == "49546986683135544286507457936321625675700192471156785155"
Expand Down