Skip to content

fix(event_source): kinesis subsequenceNumber str type to int #3275

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 31, 2023
Merged

fix(event_source): kinesis subsequenceNumber str type to int #3275

merged 2 commits into from
Oct 31, 2023

Conversation

roger-zhangg
Copy link
Member

Issue number: #3237

Summary

Changes

Please provide a summary of what's being changed
Changed typing of all variables related to kinesisRecordMetadata.subsequenceNumber from str to int.

User experience

Please share what the user experience looks like before and after this change
Resolved the bug.

Checklist

If your change doesn't seem to apply, please leave them unchecked.

Is this a breaking change?

RFC issue number:

Checklist:

  • Migration process documented
  • Implement warnings (if it can live side by side)

Acknowledgment

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.

@roger-zhangg roger-zhangg requested a review from a team October 31, 2023 00:01
@boring-cyborg boring-cyborg bot added the tests label Oct 31, 2023
@pull-request-size pull-request-size bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Oct 31, 2023
@roger-zhangg roger-zhangg changed the title change subsequenceNumber from str to int fix(data-class): change subsequenceNumber from str to int Oct 31, 2023
@leandrodamascena leandrodamascena linked an issue Oct 31, 2023 that may be closed by this pull request
Bug: The KinesisFirehoseRecordMetadata model is typed incorrectly and forces a pydantic ValidationError. #3237
Closed
@leandrodamascena leandrodamascena changed the title fix(data-class): change subsequenceNumber from str to int fix(event_source): change kinesisRecordMetadata subsequenceNumber from str to int Oct 31, 2023
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
7.5% 7.5% Duplication

@leandrodamascena leandrodamascena changed the title fix(event_source): change kinesisRecordMetadata subsequenceNumber from str to int fix(event_source): kinesis subsequenceNumber str type to int Oct 31, 2023
@leandrodamascena leandrodamascena merged commit b3c9ee0 into aws-powertools:develop Oct 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leandrodamascena leandrodamascena leandrodamascena approved these changes

Assignees
No one assigned
Labels
size/S Denotes a PR that changes 10-29 lines, ignoring generated files. tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug: The KinesisFirehoseRecordMetadata model is typed incorrectly and forces a pydantic ValidationError.
2 participants
@roger-zhangg @leandrodamascena