-
-
Notifications
You must be signed in to change notification settings - Fork 445
Various fixes from arduino/arduino-pro-ide/issues #9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
From now on, compile/upload is not verbose. Closes arduino/arduino-pro-ide#422. Signed-off-by: Akos Kitta <[email protected]>
Updated to lates Theia: `1.11.0-next.c9db9754`. Signed-off-by: Akos Kitta <[email protected]>
Signed-off-by: Akos Kitta <[email protected]>
Closes arduino/arduino-pro-ide#423 Signed-off-by: Akos Kitta <[email protected]>
Closes #7 Signed-off-by: Akos Kitta <[email protected]>
Signed-off-by: Akos Kitta <[email protected]>
Signed-off-by: Akos Kitta <[email protected]>
Signed-off-by: Akos Kitta <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
build tested and working for each of the fixes except the Windows one which I cannot test
Tested and working on Windows 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested Everything on windows and it works.
Nice job!
Thanks for the great work Akos. Super awesome how you were able to make these fixes and improvements Regarding this:
I spotted an issue. It might be something to deal with separately, if so I can open an issue, but I thought I should mention it here: Describe the bug To Reproduce
For example, if I have this sketch saved: void setup() {}
void loop() {} and this is the dirty version: foovoid setup() {}
void loop() {} The compilation error:
|
The compilation error if I save the sketch:
I'm not sure what is going on with the doubled output and that stray |
I can confirm the bug. I think it might be a CLI issue. I am not doing anything special, but using the appropriate CLI API. |
I see this issue (but not #12) also occurs in Java IDE 1.8.13. The duplicate error messages are caused by the error propagating to the hidden function prototype generated during sketch preprocessing: #include <Arduino.h>
#line 1 "C:\\Users\\per\\Documents\\Arduino\\Issue12\\Issue12.ino"
#line 1 "C:\\Users\\per\\Documents\\Arduino\\Issue12\\Issue12.ino"
foovoid setup();
#line 2 "C:\\Users\\per\\Documents\\Arduino\\Issue12\\Issue12.ino"
void loop();
#line 1 "C:\\Users\\per\\Documents\\Arduino\\Issue12\\Issue12.ino"
foovoid setup() {}
void loop() {} And the |
~/.arduinoIDE/settings.json
)always_export_binaries
CLI config. (Try to change thealways_export_binaries
CLI config and check for thebuild
folder. You have to restart the app after changing thealways_export_binaries
. This is how it is now, I can expose it to the Settings UI if required)