Skip to content

Dirty exit dialog choice is ignored #63

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
per1234 opened this issue Feb 10, 2021 · 3 comments
Closed

Dirty exit dialog choice is ignored #63

per1234 opened this issue Feb 10, 2021 · 3 comments
Assignees
Labels
conclusion: resolved Issue was resolved os: windows Specific to Windows operating system topic: code Related to content of the project itself type: imperfection Perceived defect in any part of project

Comments

@per1234
Copy link
Contributor

per1234 commented Feb 10, 2021

Describe the bug
When closing a sketch with unsaved changes, the user is prompted whether they want to exit without saving "Are you sure you want to close the sketch?":
Clipboard01
If they click the "No" button, the exit occurs anyway and the unsaved changes are lost.

To Reproduce
Steps to reproduce the behavior:

  1. File > Preferences
  2. Uncheck the box next to "Auto save".
  3. Click the "OK" button.
  4. Make changes to a sketch without saving.
  5. Close the sketch (by doing any of File > Close, File > Quit, or closing the window). The "Are you sure you want to close the sketch?" should be shown.
  6. Click the "No" button. The sketch will close anyway and the unsaved changes will be lost.

Expected behavior
When the user clicks "No" on the "Are you sure you want to close the sketch?" dialog, the sketch should not be closed.

Desktop (please complete the following information):

  • OS: Windows 10
  • Version: 0.1.4
    Date: 2021-02-10T12:24:17.658Z
    CLI Version: 0.15.2 alpha [0d4cb150]
@kittaakos
Copy link
Contributor

It works on macOS, but I could reproduce it on Windows. I need to verify it on Linux too.

@kittaakos
Copy link
Contributor

I have fixed and verified it on Windows. We will make this available to the public soon.

@kittaakos kittaakos self-assigned this Feb 11, 2021
@rsora rsora transferred this issue from arduino/arduino-pro-ide Mar 1, 2021
@per1234
Copy link
Contributor Author

per1234 commented Mar 1, 2021

Closing as fixed by 7568a0c
Thanks Akos!

@per1234 per1234 closed this as completed Mar 1, 2021
@silvanocerza silvanocerza added type: bug os: windows Specific to Windows operating system labels Mar 1, 2021
@rsora rsora added the type: imperfection Perceived defect in any part of project label Sep 22, 2021
@per1234 per1234 added conclusion: resolved Issue was resolved topic: code Related to content of the project itself labels Oct 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
conclusion: resolved Issue was resolved os: windows Specific to Windows operating system topic: code Related to content of the project itself type: imperfection Perceived defect in any part of project
Projects
None yet
Development

No branches or pull requests

4 participants