Skip to content

Adds multiple host handling via DSN parsing #257

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion asyncpg/connect_utils.py
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,7 @@ def _parse_connect_dsn_and_args(*, dsn, host, port, user,
port = int(parsed.port)

if parsed.hostname and host is None:
host = parsed.hostname
host = parsed.hostname.split(',')

if parsed.path and database is None:
database = parsed.path
Expand Down
8 changes: 8 additions & 0 deletions tests/test_connect.py
Original file line number Diff line number Diff line change
Expand Up @@ -316,6 +316,14 @@ class TestConnectParams(tb.TestCase):
'dsn': 'pq:///dbname?host=/unix_sock/test&user=spam',
'error': (ValueError, 'invalid DSN')
},

{
'dsn': 'postgres://user3:123123@localhost,127.0.0.1:5555/abcdef',
'result': ([('localhost', 5555), ('127.0.0.1', 5555)], {
'user': 'user3',
'password': '123123',
'database': 'abcdef'})
},
]

@contextlib.contextmanager
Expand Down