Adds multiple host handling via DSN parsing #257
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elprans
approved these changes
Mar 4, 2018
egalpin
force-pushed
the
add-multi-host-dsn
branch
from
5832722 to
f5654bd
Compare
|
Done 👍 |
elprans
requested changes
Mar 5, 2018
There was a problem hiding this comment.
Actually, looking closer, I don't think the parsing is correct.
The general URI form is:
postgresql://[user[:password]@][netloc][:port][,...][/dbname][?param1=value1&...]
So, each comma-separated part has its own user/password/host/port tuple, while your implementation assumes that it's only the host part that is comma-separated sharing the other connection bits.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If there is a way to do this by formatting a DSN in a way the urllib.parse can already handle, please feel free to document here and close this out. Thanks!