Skip to content

Fix fork workflows #1377

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

oleksandr-pavlyk
Copy link
Contributor

Opening a PR from my fork of dpctl to test changes to "conda-packages.yaml" workflow (step about array-api-conformity) and to "generate-docs.yaml" worflow.

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to an issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • If this PR is a work in progress, are you opening the PR as a draft?

Also adds a step to output array-api-test summary into the log
(step which works for PRs regardless whether they are opened from
a fork, or from a branch in this repo).
Only publish sources and comments with link to them for PRs
opened from branches in this repo. PRs from forks would have
artifacts with rendered docs uploaded.
@coveralls
Copy link
Collaborator

coveralls commented Aug 28, 2023

Coverage Status

coverage: 85.626%. remained the same when pulling e06bf40 on oleksandr-pavlyk:fix-fork-workflows into 526c46c on IntelPython:master.

Copy link
Collaborator

@ndgrigorian ndgrigorian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes to the array API conformity and documentation generation are all working correctly

Great changes, thanks @oleksandr-pavlyk

@oleksandr-pavlyk oleksandr-pavlyk merged commit 9f98baf into IntelPython:master Aug 28, 2023
@oleksandr-pavlyk oleksandr-pavlyk deleted the fix-fork-workflows branch August 28, 2023 20:30
oleksandr-pavlyk added a commit that referenced this pull request Apr 19, 2024
gh-1377 has made changes to condition of executing "Publish Docs"
step which resulted in that condition always evaluating to False,
and documentation changes were not uploaded for 8 months since the
merge of that PR.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants