Skip to content

Commit 526c46c

Browse files
Merge pull request #1376 from PiotrekB416/feature/lowercase-tensor-copy
Addressed issue with lowercase order value in tensor copy and astype
2 parents a4fe4ad + 5390456 commit 526c46c

File tree

1 file changed

+8
-3
lines changed

1 file changed

+8
-3
lines changed

dpctl/tensor/_copy_utils.py

Lines changed: 8 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -517,6 +517,11 @@ def copy(usm_ary, order="K"):
517517
- "K": match the layout of `usm_ary` as closely as possible.
518518
519519
"""
520+
if len(order) == 0 or order[0] not in "KkAaCcFf":
521+
raise ValueError(
522+
"Unrecognized order keyword value, expecting 'K', 'A', 'F', or 'C'."
523+
)
524+
order = order[0].upper()
520525
if not isinstance(usm_ary, dpt.usm_ndarray):
521526
return TypeError(
522527
f"Expected object of type dpt.usm_ndarray, got {type(usm_ary)}"
@@ -585,11 +590,11 @@ def astype(usm_ary, newdtype, order="K", casting="unsafe", copy=True):
585590
return TypeError(
586591
f"Expected object of type dpt.usm_ndarray, got {type(usm_ary)}"
587592
)
588-
if not isinstance(order, str) or order not in ["A", "C", "F", "K"]:
593+
if len(order) == 0 or order[0] not in "KkAaCcFf":
589594
raise ValueError(
590-
"Unrecognized value of the order keyword. "
591-
"Recognized values are 'A', 'C', 'F', or 'K'"
595+
"Unrecognized order keyword value, expecting 'K', 'A', 'F', or 'C'."
592596
)
597+
order = order[0].upper()
593598
ary_dtype = usm_ary.dtype
594599
target_dtype = _get_dtype(newdtype, usm_ary.sycl_queue)
595600
if not dpt.can_cast(ary_dtype, target_dtype, casting=casting):

0 commit comments

Comments
 (0)