Skip to content

chore(profiler): remove resolved known issue for profiler on Python 3.11 [backport #5153 to 1.8] #5154

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 17, 2023

Conversation

ZStriker19
Copy link
Contributor

Backport of #5153 to 1.8

This PR removes the known issue release note for the profiler on Python 3.11 relating to PyFrameObjects, which was mitigated by #5019.

Checklist

  • Change(s) are motivated and described in the PR description.
  • Testing strategy is described if automated tests are not included in the PR.
  • Risk is outlined (performance impact, potential for breakage, maintainability, etc).
  • Change is maintainable (easy to change, telemetry, documentation).
  • Library release note guidelines are followed.
  • Documentation is included (in-code, generated user docs, public corp docs).
  • Author is aware of the performance implications of this PR as reported in the benchmarks PR comment.

Reviewer Checklist

  • Title is accurate.
  • No unnecessary changes are introduced.
  • Description motivates each change.
  • Avoids breaking API changes unless absolutely necessary.
  • Testing strategy adequately addresses listed risk(s).
  • Change is maintainable (easy to change, telemetry, documentation).
  • Release note makes sense to a user of the library.
  • Reviewer is aware of, and discussed the performance implications of this PR as reported in the benchmarks PR comment.

….11 (#5153)

This PR removes the known issue release note for the profiler on Python
3.11 relating to `PyFrameObjects`, which was mitigated by #5019.
## Checklist

- [x] Change(s) are motivated and described in the PR description.
- [x] Testing strategy is described if automated tests are not included
in the PR.
- [x] Risk is outlined (performance impact, potential for breakage,
maintainability, etc).
- [x] Change is maintainable (easy to change, telemetry, documentation).
- [x] [Library release note
guidelines](https://ddtrace.readthedocs.io/en/stable/contributing.html#Release-Note-Guidelines)
are followed.
- [x] Documentation is included (in-code, generated user docs, [public
corp docs](https://github.com/DataDog/documentation/)).
- [x] Author is aware of the performance implications of this PR as
reported in the benchmarks PR comment.

## Reviewer Checklist

- [x] Title is accurate.
- [x] No unnecessary changes are introduced.
- [x] Description motivates each change.
- [x] Avoids breaking
[API](https://ddtrace.readthedocs.io/en/stable/versioning.html#interfaces)
changes unless absolutely necessary.
- [x] Testing strategy adequately addresses listed risk(s).
- [x] Change is maintainable (easy to change, telemetry, documentation).
- [x] Release note makes sense to a user of the library.
- [x] Reviewer is aware of, and discussed the performance implications
of this PR as reported in the benchmarks PR comment.

(cherry picked from commit 066688c)
@ZStriker19 ZStriker19 requested a review from a team as a code owner February 17, 2023 20:36
@ZStriker19 ZStriker19 added the changelog/no-changelog A changelog entry is not required for this PR. label Feb 17, 2023
@ZStriker19 ZStriker19 enabled auto-merge (squash) February 17, 2023 20:37
@brettlangdon
Copy link
Member

I am force merging this without having the tests complete first because this is the deletion of a release note.

@brettlangdon brettlangdon merged commit 55525ba into 1.8 Feb 17, 2023
@brettlangdon brettlangdon deleted the test-backport-5153-to-1.8 branch February 17, 2023 20:39
@github-actions github-actions bot added this to the v1.8.0 milestone Feb 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog/no-changelog A changelog entry is not required for this PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants