fix(profiler): handle non-frame objects while stack-unwinding #5019
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brettlangdon
reviewed
Feb 1, 2023
P403n1x87
force-pushed
the
fix/profiler-py311-alien-frame-objects
branch
from
450cb19 to
735b639
Compare
Yun-Kim
reviewed
Feb 1, 2023
releasenotes/notes/profiler-py311-alien-frame-objects-a7eca2f7dd3270c1.yaml
Outdated
Show resolved
Hide resolved
Following reports of Python 3.11 returning non-frame objects while unwinding the stack of a running thread, this change adds handling code that prevents exceptions from being raised.
P403n1x87
changed the title
P403n1x87
force-pushed
the
fix/profiler-py311-alien-frame-objects
branch
from
735b639 to
8e73fd6
Compare
P403n1x87
force-pushed
the
fix/profiler-py311-alien-frame-objects
branch
from
4cd5af9 to
d4a7773
Compare
Codecov Report
@@ Coverage Diff @@
## 1.x #5019 +/- ##
==========================================
+ Coverage 74.92% 74.95% +0.02%
==========================================
Files 824 824
Lines 63823 63823
==========================================
+ Hits 47820 47837 +17
+ Misses 16003 15986 -17
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
brettlangdon
previously approved these changes
Feb 1, 2023
Yun-Kim
requested changes
Feb 1, 2023
releasenotes/notes/profiler-py311-alien-frame-objects-a7eca2f7dd3270c1.yaml
Outdated
Show resolved
Hide resolved
…dd3270c1.yaml Co-authored-by: Yun Kim <[email protected]>
emmettbutler
approved these changes
Feb 2, 2023
Yun-Kim
approved these changes
Feb 2, 2023
brettlangdon
approved these changes
Feb 2, 2023
11 tasks
Closed
13 tasks
13 tasks
brettlangdon
pushed a commit
that referenced
this pull request
Feb 10, 2023
Following reports of Python 3.11 returning non-frame objects while unwinding the stack of a running thread, this change adds handling code that prevents exceptions from being raised. (cherry picked from commit ea7c9c6)
majorgreys
pushed a commit
that referenced
this pull request
Feb 10, 2023
…rt 1.8] (#5091) Backport ea7c9c6 from #5019 to 1.8. Following reports of Python 3.11 returning non-frame objects while unwinding the stack of a running thread, this change adds handling code that prevents exceptions from being raised. ## Checklist - [x] Change(s) are motivated and described in the PR description. - [x] Testing strategy is described if automated tests are not included in the PR. - [x] Risk is outlined (performance impact, potential for breakage, maintainability, etc). - [x] Change is maintainable (easy to change, telemetry, documentation). - [x] [Library release note guidelines](https://ddtrace.readthedocs.io/en/stable/contributing.html#Release-Note-Guidelines) are followed. - [x] Documentation is included (in-code, generated user docs, [public corp docs](https://github.com/DataDog/documentation/)). ## Reviewer Checklist - [x] Title is accurate. - [x] No unnecessary changes are introduced. - [x] Description motivates each change. - [x] Avoids breaking [API](https://ddtrace.readthedocs.io/en/stable/versioning.html#interfaces) changes unless absolutely necessary. - [x] Testing strategy adequately addresses listed risk(s). - [x] Change is maintainable (easy to change, telemetry, documentation). - [x] Release note makes sense to a user of the library. Co-authored-by: Gabriele N. Tornetta <[email protected]>
brettlangdon
pushed a commit
that referenced
this pull request
Feb 10, 2023
Following reports of Python 3.11 returning non-frame objects while unwinding the stack of a running thread, this change adds handling code that prevents exceptions from being raised. (cherry picked from commit ea7c9c6)
13 tasks
brettlangdon
pushed a commit
that referenced
this pull request
Feb 10, 2023
Following reports of Python 3.11 returning non-frame objects while unwinding the stack of a running thread, this change adds handling code that prevents exceptions from being raised. (cherry picked from commit ea7c9c6)
brettlangdon
pushed a commit
that referenced
this pull request
Feb 10, 2023
Following reports of Python 3.11 returning non-frame objects while unwinding the stack of a running thread, this change adds handling code that prevents exceptions from being raised. (cherry picked from commit ea7c9c6)
13 tasks
brettlangdon
pushed a commit
that referenced
this pull request
Feb 10, 2023
…rt 1.7] (#5090) Backport ea7c9c6 from #5019 to 1.7. Following reports of Python 3.11 returning non-frame objects while unwinding the stack of a running thread, this change adds handling code that prevents exceptions from being raised. ## Checklist - [x] Change(s) are motivated and described in the PR description. - [x] Testing strategy is described if automated tests are not included in the PR. - [x] Risk is outlined (performance impact, potential for breakage, maintainability, etc). - [x] Change is maintainable (easy to change, telemetry, documentation). - [x] [Library release note guidelines](https://ddtrace.readthedocs.io/en/stable/contributing.html#Release-Note-Guidelines) are followed. - [x] Documentation is included (in-code, generated user docs, [public corp docs](https://github.com/DataDog/documentation/)). ## Reviewer Checklist - [x] Title is accurate. - [x] No unnecessary changes are introduced. - [x] Description motivates each change. - [x] Avoids breaking [API](https://ddtrace.readthedocs.io/en/stable/versioning.html#interfaces) changes unless absolutely necessary. - [x] Testing strategy adequately addresses listed risk(s). - [x] Change is maintainable (easy to change, telemetry, documentation). - [x] Release note makes sense to a user of the library. Co-authored-by: Gabriele N. Tornetta <[email protected]>
15 tasks
ZStriker19
pushed a commit
that referenced
this pull request
Feb 17, 2023
….11 (#5153) This PR removes the known issue release note for the profiler on Python 3.11 relating to `PyFrameObjects`, which was mitigated by #5019. ## Checklist - [x] Change(s) are motivated and described in the PR description. - [x] Testing strategy is described if automated tests are not included in the PR. - [x] Risk is outlined (performance impact, potential for breakage, maintainability, etc). - [x] Change is maintainable (easy to change, telemetry, documentation). - [x] [Library release note guidelines](https://ddtrace.readthedocs.io/en/stable/contributing.html#Release-Note-Guidelines) are followed. - [x] Documentation is included (in-code, generated user docs, [public corp docs](https://github.com/DataDog/documentation/)). - [x] Author is aware of the performance implications of this PR as reported in the benchmarks PR comment. ## Reviewer Checklist - [x] Title is accurate. - [x] No unnecessary changes are introduced. - [x] Description motivates each change. - [x] Avoids breaking [API](https://ddtrace.readthedocs.io/en/stable/versioning.html#interfaces) changes unless absolutely necessary. - [x] Testing strategy adequately addresses listed risk(s). - [x] Change is maintainable (easy to change, telemetry, documentation). - [x] Release note makes sense to a user of the library. - [x] Reviewer is aware of, and discussed the performance implications of this PR as reported in the benchmarks PR comment.
ZStriker19
pushed a commit
that referenced
this pull request
Feb 17, 2023
….11 (#5153) This PR removes the known issue release note for the profiler on Python 3.11 relating to `PyFrameObjects`, which was mitigated by #5019. ## Checklist - [x] Change(s) are motivated and described in the PR description. - [x] Testing strategy is described if automated tests are not included in the PR. - [x] Risk is outlined (performance impact, potential for breakage, maintainability, etc). - [x] Change is maintainable (easy to change, telemetry, documentation). - [x] [Library release note guidelines](https://ddtrace.readthedocs.io/en/stable/contributing.html#Release-Note-Guidelines) are followed. - [x] Documentation is included (in-code, generated user docs, [public corp docs](https://github.com/DataDog/documentation/)). - [x] Author is aware of the performance implications of this PR as reported in the benchmarks PR comment. ## Reviewer Checklist - [x] Title is accurate. - [x] No unnecessary changes are introduced. - [x] Description motivates each change. - [x] Avoids breaking [API](https://ddtrace.readthedocs.io/en/stable/versioning.html#interfaces) changes unless absolutely necessary. - [x] Testing strategy adequately addresses listed risk(s). - [x] Change is maintainable (easy to change, telemetry, documentation). - [x] Release note makes sense to a user of the library. - [x] Reviewer is aware of, and discussed the performance implications of this PR as reported in the benchmarks PR comment. (cherry picked from commit 066688c)
15 tasks
brettlangdon
pushed a commit
that referenced
this pull request
Feb 17, 2023
….11 [backport #5153 to 1.8] (#5154) Backport of #5153 to 1.8 This PR removes the known issue release note for the profiler on Python 3.11 relating to `PyFrameObjects`, which was mitigated by #5019. ## Checklist - [x] Change(s) are motivated and described in the PR description. - [x] Testing strategy is described if automated tests are not included in the PR. - [x] Risk is outlined (performance impact, potential for breakage, maintainability, etc). - [x] Change is maintainable (easy to change, telemetry, documentation). - [x] [Library release note guidelines](https://ddtrace.readthedocs.io/en/stable/contributing.html#Release-Note-Guidelines) are followed. - [x] Documentation is included (in-code, generated user docs, [public corp docs](https://github.com/DataDog/documentation/)). - [x] Author is aware of the performance implications of this PR as reported in the benchmarks PR comment. ## Reviewer Checklist - [x] Title is accurate. - [x] No unnecessary changes are introduced. - [x] Description motivates each change. - [x] Avoids breaking [API](https://ddtrace.readthedocs.io/en/stable/versioning.html#interfaces) changes unless absolutely necessary. - [x] Testing strategy adequately addresses listed risk(s). - [x] Change is maintainable (easy to change, telemetry, documentation). - [x] Release note makes sense to a user of the library. - [x] Reviewer is aware of, and discussed the performance implications of this PR as reported in the benchmarks PR comment. Co-authored-by: Yun Kim <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following reports of Python 3.11 returning non-frame objects while unwinding the stack of a running thread, this change adds handling code that prevents exceptions from being raised.
Checklist
Reviewer Checklist