Skip to content

Enable Windows CI #39

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 19 commits into from
May 6, 2018
Merged

Enable Windows CI #39

merged 19 commits into from
May 6, 2018

Conversation

ianfixes
Copy link
Collaborator

@ianfixes ianfixes commented Apr 25, 2018

tomduff and others added 5 commits May 5, 2018 10:57
Windows compilation support

* Updated arduino self.existing_executable function to find arduino_debug.exe
* Added compilers to .arduino-ci.yaml so that build runs
* Added error handling around the reg lookup so that it does not just bomb out and runs to the force install function.
* Corrected the incorrect reg key used to allow testing of force download
* Switched to http for downloads to avoid ssl error
It appears that the standard way to do it is pipe to null. The logs are spammed when run locally so I am not sure if this has the desired effect
@ianfixes ianfixes force-pushed the 2018-04-25_windows_ci branch from 61ae646 to 0e548ba Compare May 6, 2018 01:45
@ianfixes
Copy link
Collaborator Author

ianfixes commented May 6, 2018

Punting #45 to future work

@ianfixes
Copy link
Collaborator Author

ianfixes commented May 6, 2018

@tomduff if you do any future work on this branch, don't worry about rubocop errors! I can tend to those for you.

@ianfixes ianfixes mentioned this pull request May 6, 2018
Switched to ruby methods for file system manipulation
Introduced dependency on rubyzip for archive extraction
@tomduff
Copy link
Contributor

tomduff commented May 6, 2018

Issue #48 was inspired by my looking at the odd compilation error in wstring.cpp.

I discovered the following which might be useful:

 // Works just fine
 long v = -2147483648L;
 assertEqual(-2147483648L, v);
 assertEqual("-2147483648", String(v));
 assertEqual("-2147483648", String((long)-2147483648L));
 assertEqual("-2147483647", String(-2147483647L));

 // Fails as expected since this blows out the long
 // v = -2147483649L;
 // assertEqual(-2147483649L, v);

 // Fails - not sure why ????
 // assertEqual("-2147483648", String(-2147483648L));

@ianfixes ianfixes mentioned this pull request May 6, 2018
@ianfixes ianfixes force-pushed the 2018-04-25_windows_ci branch from 7c2ef2e to 0a80583 Compare May 6, 2018 12:18
@ianfixes ianfixes changed the title Initial and likely very broken windows CI commit Enable Windows CI May 6, 2018
@ianfixes ianfixes merged commit 836be5c into master May 6, 2018
@ianfixes
Copy link
Collaborator Author

ianfixes commented May 6, 2018

Thanks for your help on this @tomduff !

@tomduff
Copy link
Contributor

tomduff commented May 6, 2018

@ianfixes No problem, glad I could assist.

Does the merge down to master mean a new version of the Gem will be published?

@ianfixes
Copy link
Collaborator Author

ianfixes commented May 6, 2018

Soon. I have a few stray things to clean up that are going in #50 but after that I'll roll it out.

@ianfixes
Copy link
Collaborator Author

ianfixes commented May 6, 2018

If you hadn't already seen it, v0.1.10 is out with these fixes

@ianfixes ianfixes deleted the 2018-04-25_windows_ci branch January 13, 2019 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants