cross-platform symlinking

Author: ianfixes

CHANGELOG.md

@@ -11,6 +11,7 @@ and this project adheres to [Semantic Versioning](http://semver.org/).
 - Windows / Appveyor support, enabled largely by contributions from @tomduff
 - `long long` support in `String`
 - Representative `.gitignore` files in sample projects
+- Cross-platform symlinking
 
 ### Changed
 - Author

lib/arduino_ci/arduino_cmd.rb

@@ -274,7 +274,7 @@ def install_local_library(path)
       end
 
       # install the library
-      FileUtils.ln_s(realpath, destination_path)
+      Host.symlink(realpath, destination_path)
       destination_path
     end
 

lib/arduino_ci/host.rb

@@ -37,5 +37,16 @@ def self.os
       return :windows if OS.windows?
     end
 
+    # if on windows, call mklink, else self.symlink
+    # https://stackoverflow.com/a/22716582/2063546
+    def self.symlink(old_path, new_path)
+      return FileUtils.ln_s(old_path, new_path) unless RUBY_PLATFORM =~ /mswin32|cygwin|mingw|bccwin/
+
+      # windows mklink syntax is reverse of unix ln -s
+      # windows mklink is built into cmd.exe
+      # vulnerable to command injection, but okay because this is a hack to make a cli tool work.
+      _stdin, _stdout, _stderr, wait_thr = Open3.popen3('cmd.exe', "/c mklink #{new_path} #{old_path}")
+      wait_thr.value.exitstatus
+    end
   end
 end