Skip to content

Allow no compressor for v2 arrays #3039

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
May 14, 2025

Conversation

dstansby
Copy link
Contributor

@dstansby dstansby commented May 6, 2025

Fixes #3038.

@github-actions github-actions bot added the needs release notes Automatically applied to PRs which haven't added release notes label May 6, 2025
@dstansby dstansby force-pushed the v2-no-compressor branch 3 times, most recently from 2f1190c to 5515892 Compare May 7, 2025 16:41
@dstansby dstansby force-pushed the v2-no-compressor branch from 5515892 to 2a4756a Compare May 8, 2025 09:46
@github-actions github-actions bot removed the needs release notes Automatically applied to PRs which haven't added release notes label May 8, 2025
@dstansby dstansby marked this pull request as ready for review May 8, 2025 09:46
@dstansby dstansby requested a review from d-v-b May 8, 2025 16:16
@d-v-b
Copy link
Contributor

d-v-b commented May 13, 2025

since this is changing the default behavior of some user-facing functions, I wonder if we should bundle this into a 3.1 release

@dstansby
Copy link
Contributor Author

I don't think it's changing the default behaviour (if you don't specify compressor, you still get a default compressor as before), but it is changing the behaviour of explicitly passing compressor=None. I suspect not many people are explicitly doing that (and expecting a compressor to be automatically chosen), so I'm erring on the side of it's more of a bugfix and fine for a micro release. But happy for a minor release too.

@d-v-b
Copy link
Contributor

d-v-b commented May 13, 2025

gotcha, if the default has the same behavior after this change then I think it can go in immediately

@d-v-b d-v-b enabled auto-merge (squash) May 13, 2025 11:33
@d-v-b d-v-b merged commit 629b4e5 into zarr-developers:main May 14, 2025
30 checks passed
@dstansby dstansby deleted the v2-no-compressor branch May 14, 2025 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can't use zarr.create to make v2 array with no compressor
2 participants