Detect if afunix.h exists #2145
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@yhirose I'm not sure why the |
|
@p1-0tr you don't need to worry about the abidiff error. |
yhirose
reviewed
May 23, 2025
| @@ -192,8 +192,11 @@ using ssize_t = long; | |||
| #include <winsock2.h> | |||
| #include <ws2tcpip.h> | |||
|
|
|||
| #if __has_include(<afunix.h>) | |||
There was a problem hiding this comment.
@p1-0tr this is not compatible with C++11.
There was a problem hiding this comment.
I know it only got standardised as of c++17, but has been supported by all major compilers before that. I've added an additional check that should protect against errors on compilers that do not support that macro.
yhirose
reviewed
May 23, 2025
Signed-off-by: Piotr Stankiewicz <[email protected]>
|
@p1-0tr thanks for the adjustments! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Older versions of the windows 10 SDK may not have
afunix.h. So add logic to detect if the header exists, and enableAF_UNIXonly on supported windows versions.