Bugfix help command

[sudoarslan]

Summary - Bug Fix
This PR fixes #3559

The code removes unsupported aliases from the output list of help command and also prints out the supported alias (if there is any) for the command in the same row. For clarification, please have a look at the command generate-lock-entry and upgrade-interactive in the output below, you should be able to see the alias of the commands in the same line.

Output with this fix

Usage: yarn [command] [flags]

  Options:

    -h, --help                          output usage information
    -V, --version                       output the version number
    --verbose                           output verbose messages on internal operations
    --offline                           trigger an error if any required dependencies are not available in local cache
    --prefer-offline                    use network only if dependencies are not available in local cache
    --strict-semver                     
    --json                              
    --ignore-scripts                    don't run lifecycle scripts
    --har                               save HAR output of network traffic
    --ignore-platform                   ignore platform checks
    --ignore-engines                    ignore engines check
    --ignore-optional                   ignore optional dependencies
    --force                             install and build packages even if they were built before, overwrite lockfile
    --skip-integrity-check              run install without checking if node_modules is installed
    --check-files                       install will verify file tree of packages for consistency
    --no-bin-links                      don't generate bin links when setting up packages
    --flat                              only allow one version of a package
    --prod, --production [prod]         
    --no-lockfile                       don't read or generate a lockfile
    --pure-lockfile                     don't generate a lockfile
    --frozen-lockfile                   don't generate a lockfile and fail if an update is needed
    --link-duplicates                   create hardlinks to the repeated modules in node_modules
    --global-folder <path>              specify a custom folder to store global packages
    --modules-folder <path>             rather than installing modules into the node_modules folder relative to the cwd, output them here
    --cache-folder <path>               specify a custom folder to store the yarn cache
    --mutex <type>[:specifier]          use a mutex to ensure only one yarn instance is executing
    --emoji                             enable emoji in output
    -s, --silent                        skip Yarn console logs, other types of logs (script output) will be printed
    --proxy <host>                      
    --https-proxy <host>                
    --no-progress                       disable progress bar
    --network-concurrency <number>      maximum number of concurrent network requests
    --network-timeout <milliseconds>    TCP timeout for network requests
    --non-interactive                   do not show interactive prompts
    --scripts-prepend-node-path [bool]  prepend the node executable dir to the PATH in scripts

  Commands:

    - access
    - add
    - bin
    - cache
    - check
    - clean
    - config
    - create
    - exec
    - generate-lock-entry  alias: generateLockEntry
    - global
    - help
    - import
    - info
    - init
    - install
    - licenses
    - link
    - list
    - login
    - logout
    - outdated
    - owner
    - pack
    - publish
    - remove
    - run
    - tag
    - team
    - unlink
    - upgrade
    - upgrade-interactive  alias: upgradeInteractive
    - version
    - versions
    - why
    - workspace

  Run `yarn help COMMAND` for more information on specific commands.
  Visit https://yarnpkg.com/en/docs/cli/ to learn more about Yarn.

[arcanis]

Not sure the Object.values().includes() construct will work on Node 4 :/

[sudoarslan]

Good catch. I think the proper support for Array.prototype.includes came with Node 6. I will update the PR.

[arcanis]

Could we just print - {name} / {alias1} / {alias2} / ... to be less verbose?

[sudoarslan]

I agree, that will get the job done and would look cleaner as well. I will update the PR accordingly.

[voxsim]

@arcanis and @arslanarshad31 I think we should get rid of every unsupported-alias and remove from the code and from tests as well, we discussed here and we agree, what do you think? Maybe we can do in this pull request if you are ok with that :)

[arcanis]

@voxsim I'd be ok with that - @arslanarshad31 what do you think? Would you have time to do it?

[bestander]

Ok, let's merge this as it is obviously an improvement over current situation.
But let's follow up with the removal.

[sudoarslan]

@voxsim @arcanis I think it should be fine to get rid of the unsupported aliases, I don't see them providing a very significant functionality as well and issues created because of them only slow down the development process.
Also, yes I can open a new PR in the coming days to nuke these unsupported aliases.

[bestander]

Go ahead

…

On 6 July 2017 at 21:27, Arslan Arshad ***@***.***> wrote: @voxsim <https://github.com/voxsim> @arcanis <https://github.com/arcanis> I think it should be fine to get rid of the unsupported aliases, I don't see them providing a very significant functionality as well and issues created because of them only slow down the development process. Also, yes I can open a new PR in the coming days to nuke these unsupported aliases. — You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub <#3706 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ACBdWOP8vLkNZy69iX8Jm_VDIkLEKOA0ks5sLbOWgaJpZM4ODM8v> .