Use auth tokens for NPM registry requests #1086
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bripkens
force-pushed
the
npm-auth-token
branch
from
2c953de to
e0676d7
Compare
The NPM registry and NPM compatible registries support privately hosted modules. To access meta data for these modules and the modules' tarballs themselves, bearer tokens can be used. To support this, NPM's `_auth` property need to be raed from the config and this option must be used for meta data and tarball requests as the bearer token.
bripkens
force-pushed
the
npm-auth-token
branch
from
e0676d7 to
ee679a8
Compare
|
#839 already did this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The NPM registry and NPM compatible registries support privately hosted
modules. To access meta data for these modules and the modules' tarballs
themselves, bearer tokens can be used.
To support this, NPM's
_authproperty need to be raed from the configand this option must be used for meta data and tarball requests as the
bearer token.
Test plan
I did not add tests for this as I am interested in general design feedback and intent of support first.