Skip to content

Initial RFC for publishConfig for yarn #40

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 13, 2017

Conversation

DarthHater
Copy link
Contributor

This is an initial draft for adding the ability to use publishConfig with yarn.

@bestander this is functionality that I think would be very useful for use with Nexus Repository Manager, Artifactory, etc...

@ljharb
Copy link

ljharb commented Jan 10, 2017

+1, this would be great. publishConfig is an important safety measure that npm respects, and it would be potentially very disastrous to run yarn publish in a previously npm-managed package, and accidentally make a private package irrevocably public.

@DarthHater
Copy link
Contributor Author

@ljharb I think there are currently measures to prevent that, yarn seems to pick up the private variable, so those would get shortcut, IF you have that set.

@ljharb
Copy link

ljharb commented Jan 10, 2017

Correct, but that's a big "if". Often publishConfig is the only mechanism - and that was sufficient with npm.

@bestander
Copy link
Member

Considering that this feature is already in npm I agree, this should be implemented in Yarn.
FYI, we are planning to work big on publish command in the next 3-4 months to bring some lerna features

@DarthHater
Copy link
Contributor Author

@bestander this would be cool to add in the short term, I think it would be very useful for users using a private registry. I've got a branch where I'm working on the implementation, pending approval over here.

@Daniel15
Copy link
Member

Nice! I didn't know about publishConfig. I agree with this 😃

This is somewhat related to yarnpkg/yarn#547, where I mentioned that we should have better handling for custom npm servers.

@bestander bestander merged commit cfd70d3 into yarnpkg:master Jan 13, 2017
@bestander
Copy link
Member

@DarthHater, looks like no one objects and this seems like a very important feature.
Please send the PR when you have a chance :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants