Skip to content

ci(e2e): disable fallback mode by default #1701

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 12, 2021
Merged

Conversation

merceyz
Copy link
Member

@merceyz merceyz commented Aug 15, 2020

What's the problem this PR addresses?

Not all of the projects we cover in our e2e tests work correctly in monorepos but we don't catch this because the fallback pool allows them to access undeclared dependencies as long as they are declared in the root.

How did you fix it?

Set YARN_PNP_FALLBACK_MODE=none by default in all e2e tests and opt-in where required (vue-cli)

Checklist

  • I have read the Contributing Guide.
  • I have set the packages that need to be released for my changes to be effective.
  • I have verified that all automated PR checks pass.

@merceyz merceyz requested a review from arcanis as a code owner August 15, 2020 11:37
@merceyz merceyz force-pushed the merceyz/e2e-strict branch from 17486ed to 29ca864 Compare August 15, 2020 12:21
@arcanis
Copy link
Member

arcanis commented Aug 18, 2020

Given the number of failing tests, I'd tend to merge it only after the associated fixes have landed, what do you think? Otherwise we might miss other signals.

@merceyz
Copy link
Member Author

merceyz commented Aug 18, 2020

Yeah, that was the plan, i'll change it to a draft to better reflect that

@merceyz merceyz marked this pull request as draft August 18, 2020 15:18
@merceyz merceyz force-pushed the merceyz/e2e-strict branch from 29ca864 to d77bb58 Compare August 28, 2020 11:28
@merceyz merceyz force-pushed the merceyz/e2e-strict branch 2 times, most recently from 263266a to b28b095 Compare September 27, 2020 20:13
@merceyz merceyz force-pushed the merceyz/e2e-strict branch from b28b095 to c2e523b Compare October 11, 2020 18:35
@merceyz merceyz force-pushed the merceyz/e2e-strict branch from c2e523b to b18d5a2 Compare October 25, 2020 18:11
@merceyz merceyz force-pushed the merceyz/e2e-strict branch from 27b81ca to a8307b8 Compare January 4, 2021 16:32
@merceyz merceyz force-pushed the merceyz/e2e-strict branch from a8307b8 to 2199397 Compare January 22, 2021 11:47
@merceyz merceyz force-pushed the merceyz/e2e-strict branch from 465a4d7 to 539d27b Compare March 20, 2021 15:09
@merceyz merceyz force-pushed the merceyz/e2e-strict branch from 539d27b to 71e43e2 Compare March 27, 2021 17:29
@merceyz merceyz force-pushed the merceyz/e2e-strict branch from 71e43e2 to 9eff5e3 Compare April 10, 2021 15:13
@merceyz merceyz force-pushed the merceyz/e2e-strict branch from 9eff5e3 to 4d5214c Compare April 22, 2021 22:33
@merceyz merceyz force-pushed the merceyz/e2e-strict branch 4 times, most recently from bd41a69 to fa226c4 Compare August 23, 2021 15:39
@merceyz merceyz changed the title ci(e2e): disable fallback mode ci(e2e): disable fallback mode by default Aug 24, 2021
@merceyz merceyz marked this pull request as ready for review August 24, 2021 12:03
@merceyz merceyz enabled auto-merge (squash) September 12, 2021 12:35
@arcanis arcanis disabled auto-merge October 12, 2021 14:45
@arcanis arcanis merged commit e64bb7a into master Oct 12, 2021
@arcanis arcanis deleted the merceyz/e2e-strict branch October 12, 2021 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants