-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
ci(e2e): disable fallback mode by default #1701
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
17486ed
to
29ca864
Compare
Given the number of failing tests, I'd tend to merge it only after the associated fixes have landed, what do you think? Otherwise we might miss other signals. |
Yeah, that was the plan, i'll change it to a draft to better reflect that |
29ca864
to
d77bb58
Compare
d77bb58
to
01e97de
Compare
263266a
to
b28b095
Compare
b28b095
to
c2e523b
Compare
c2e523b
to
b18d5a2
Compare
b18d5a2
to
27b81ca
Compare
27b81ca
to
a8307b8
Compare
a8307b8
to
2199397
Compare
2199397
to
465a4d7
Compare
465a4d7
to
539d27b
Compare
539d27b
to
71e43e2
Compare
71e43e2
to
9eff5e3
Compare
9eff5e3
to
4d5214c
Compare
bd41a69
to
fa226c4
Compare
fa226c4
to
ddfc92b
Compare
arcanis
approved these changes
Oct 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's the problem this PR addresses?
Not all of the projects we cover in our e2e tests work correctly in monorepos but we don't catch this because the fallback pool allows them to access undeclared dependencies as long as they are declared in the root.
How did you fix it?
Set
YARN_PNP_FALLBACK_MODE=none
by default in all e2e tests and opt-in where required (vue-cli)Checklist