[Woo POS][Coupons] Coupons search #14101

samiuelson · 2025-05-22T16:28:09Z

Coupons Search in Woo POS

Description

This PR adds coupons search feature in Woo POS.

💡 I added a "do not merge" label to wait for the follow-up PRs to be merged into this PR first, to ship the feature as a whole.

Next PRs:

[Woo POS][Coupons] Recent searches #14104

Steps to reproduce

N/A

Testing information

Go to Woo POS > Coupons > Search
Verify that remote search works
Verify pagination of remote search results works

The tests that have been performed

Above

Images/gif

Screen_recording_20250523_154316.mp4

I have considered if this change warrants release notes and have added them to RELEASE-NOTES.txt if necessary. Use the "[Internal]" label for non-user-facing changes.

dangermattic · 2025-05-22T16:29:32Z

	3 Errors
🚫	Please add tests for class `WooPosCouponsSearchDataSource` (or add `unit-tests-exemption` label to ignore this).
🚫	Please add tests for class `WooPosCouponsSearchViewModel` (or add `unit-tests-exemption` label to ignore this).
🚫	This PR is tagged with `status: do not merge` label(s).

	1 Warning
⚠️	This PR is larger than 300 lines of changes. Please consider splitting it into smaller PRs for easier and faster reviews.

Generated by 🚫 Danger

wpmobilebot · 2025-05-22T16:37:21Z

📲 You can test the changes from this Pull Request in WooCommerce-Wear Android by scanning the QR code below to install the corresponding build.

	App Name	WooCommerce-Wear Android
	Platform	⌚️ Wear OS
	Flavor	Jalapeno
	Build Type	Debug
	Commit	`b17b710`
	Direct Download	`woocommerce-wear-prototype-build-pr14101-b17b710.apk`

wpmobilebot · 2025-05-23T10:46:00Z

📲 You can test the changes from this Pull Request in WooCommerce Android by scanning the QR code below to install the corresponding build.

	App Name	WooCommerce Android
	Platform	📱 Mobile
	Flavor	Jalapeno
	Build Type	Debug
	Commit	`b17b710`
	Direct Download	`woocommerce-prototype-build-pr14101-b17b710.apk`

Copilot

Pull Request Overview

This pull request introduces coupon search functionality to the Woo POS app by adding new string resources, analytics updates, new view models/screens, and navigation changes.

Added new string resources and error messages for coupon search
Renamed and updated analytics event properties for consistency
Added new view models, composables, and data source support for searching coupons
Updated toolbar and screen navigation logic to integrate the coupon search UI

Reviewed Changes

Copilot reviewed 16 out of 16 changed files in this pull request and generated 3 comments.

Show a summary per file

File	Description
WooCommerce/src/main/res/values/strings.xml	Introduces new localized strings for coupon search UI messages and error prompts.
WooCommerce/src/main/kotlin/com/woocommerce/android/ui/woopos/util/analytics/WooPosAnalyticsEvent.kt	Renames the analytics event property from totalProductsCount to totalItemsCount.
WooCommerce/src/main/kotlin/com/woocommerce/android/ui/woopos/home/items/search/WooPosCouponsSearchScreen.kt	Creates a new composable screen for coupon search with a placeholder implementation.
WooCommerce/src/main/kotlin/com/woocommerce/android/ui/woopos/home/items/coupons/search/…	Adds view state, view model, UI events, and data source for handling coupon search.
WooCommerce/src/main/kotlin/com/woocommerce/android/ui/woopos/home/items/WooPosItemsViewState.kt	Adjusts search state and visibility flags for coupon and product lists.
WooCommerce/src/main/kotlin/com/woocommerce/android/ui/woopos/home/items/WooPosItemsToolbar.kt	Updates toolbar layout paddings and search state handling for coupons.
WooCommerce/src/main/kotlin/com/woocommerce/android/ui/woopos/home/items/WooPosItemsSearchHelper.kt	Modifies search helper to select the appropriate search hint based on the list type.
WooCommerce/src/main/kotlin/com/woocommerce/android/ui/woopos/home/items/WooPosItemsScreen.kt	Enhances navigation logic to include a separate screen state for coupon search.

...lin/com/woocommerce/android/ui/woopos/home/items/coupons/search/WooPosCouponsSearchScreen.kt

Copilot · 2025-05-23T14:03:11Z

WooCommerce/src/main/kotlin/com/woocommerce/android/ui/woopos/home/items/WooPosItemsToolbar.kt

            Row(
                modifier = Modifier
                    .fillMaxWidth()
-                    .padding(start = WooPosSpacing.Medium.value.toAdaptivePadding()),
+                    .padding(start = WooPosSpacing.Medium.value.toAdaptivePadding(), end = 64.dp),


[nitpick] Consider extracting the hard-coded value '64.dp' into a design system constant to maintain consistent spacing across the app.

This custom end padding is needed to uncover the search icon; Previously, the search icon was hidden behind "+" icon. To make it cleaner, we'd need to refactor the WooPosSearchInput component, which needs to fill the whole width of the toolbar and show the search icon on its right end internally.

Copilot · 2025-05-23T14:03:12Z

...ommerce/src/main/kotlin/com/woocommerce/android/ui/woopos/home/items/WooPosItemsViewState.kt

@@ -14,14 +14,15 @@ sealed class WooPosItemsViewState(
    ) : WooPosItemsViewState(
        tabs = tabs,
        search = search,
-        isAddCouponVisible = true,
+        isAddCouponVisible = false,


[nitpick] Please confirm that setting 'isAddCouponVisible' to false for the ProductList is intentional. If so, consider adding a comment to clarify why the add coupon button is hidden for this view.

Previously the sarch button was behind the "+" button; now we are showing both buttons next to each other.

samiuelson · 2025-05-23T14:29:58Z

...erce/android/ui/woopos/home/items/coupons/search/WooPosCouponsEmptySearchQueryStateScreen.kt

+    modifier: Modifier = Modifier,
+    onUIEvent: (WooPosCouponsSearchUiEvent) -> Unit
+) {
+   // TODO: implement recent coupon searches row


TBD in next PR: #14101

…-feature

Copilot

Pull Request Overview

This PR introduces a coupons search feature for Woo POS, enhancing the UI and analytics reporting for coupon-related actions.

Adds localized strings for coupon search screens and error states.
Updates analytics events and UI view states to support coupon search.
Introduces new screens, view models, and data sources for handling coupon search functionality.

Reviewed Changes

Copilot reviewed 14 out of 14 changed files in this pull request and generated 1 comment.

Show a summary per file

File	Description
res/values/strings.xml	Added string resources for coupon search titles, empty states, and error messages.
ui/woopos/util/analytics/WooPosAnalyticsEvent.kt	Renamed parameter from totalProductsCount to totalItemsCount for generalized reporting.
ui/woopos/home/items/coupons/search/*	Introduced view state, view model, UI events, and composables for coupon search.
ui/woopos/home/items/WooPosItemsViewState.kt & WooPosItemsViewModel.kt	Adjusted coupon list state configuration, including visibility of coupon creation action.
ui/woopos/home/items/WooPosItemsToolbar.kt	Updated toolbar layout with additional end padding and minor spacing adjustments.
ui/woopos/home/items/WooPosItemsSearchHelper.kt & WooPosItemsScreen.kt	Modified search helper and screen navigation logic to support coupon search state.

Comments suppressed due to low confidence (1)

WooCommerce/src/main/res/values/strings.xml:4427

The error description for coupon search still reuses the generic products error text. Consider adding a dedicated coupons error description for improved clarity and consistency on the coupons search screen.

<string name="woopos_search_items_error_description">Please try again.</string>

WooCommerce/src/main/kotlin/com/woocommerce/android/ui/woopos/home/items/WooPosItemsToolbar.kt

samiuelson added 3 commits May 22, 2025 17:39

Display search icon in Coupons tab's toolbar

5b2ec9d

Allow opening search bar in Coupons tab

ecc36a5

Show Coupons-specific hint in search bar

b33ede2

samiuelson changed the title ~~Wooprd 527 woo poscoupons add coupon search feature~~ [Woo POS][Coupons] Coupons search May 22, 2025

Satisfy detekt's complaints

e278fb8

samiuelson added 7 commits May 22, 2025 18:40

Introduce ScreenState.COUPONS_SEARCH UI state

ca7f593

Implement WooPosCouponsSearchDataSource

8403159

Create WooPosCouponsSearchViewState model

c71462a

Update param name

b0ce2c5

Implement WooPosCouponsSearchViewModel

fc22f01

Implement WooPosCouponsSearchUiEvent

5e30b17

Implement search results UI

e8af3e6

samiuelson requested a review from Copilot May 23, 2025 14:02

Copilot AI reviewed May 23, 2025

View reviewed changes

samiuelson added this to the 22.5 milestone May 23, 2025

Clean up code

1481c05

samiuelson added the status: do not merge Dependent on another PR, ready for review but not ready for merge. label May 23, 2025

samiuelson commented May 23, 2025

View reviewed changes

samiuelson added 2 commits May 23, 2025 16:31

Clean up code

d6f84be

Merge branch 'trunk' into wooprd-527-woo-poscoupons-add-coupon-search…

52b1706

…-feature

samiuelson mentioned this pull request May 23, 2025

[Woo POS][Coupons] Recent searches #14104

Open

1 task

samiuelson requested review from malinajirka and Copilot May 23, 2025 20:24

Copilot AI reviewed May 23, 2025

View reviewed changes

WooCommerce/src/main/kotlin/com/woocommerce/android/ui/woopos/home/items/WooPosItemsToolbar.kt Show resolved Hide resolved

samiuelson marked this pull request as ready for review May 23, 2025 20:30

Clean up code

b17b710

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[Woo POS][Coupons] Coupons search #14101

[Woo POS][Coupons] Coupons search #14101

samiuelson commented May 22, 2025 •

edited

Loading

Uh oh!

dangermattic commented May 22, 2025 •

edited

Loading

Uh oh!

wpmobilebot commented May 22, 2025 •

edited

Loading

Uh oh!

wpmobilebot commented May 23, 2025 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Copilot AI May 23, 2025

Uh oh!

samiuelson May 23, 2025 •

edited

Loading

Uh oh!

Copilot AI May 23, 2025

Uh oh!

samiuelson May 23, 2025

Uh oh!

samiuelson May 23, 2025 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

[Woo POS][Coupons] Coupons search #14101

Are you sure you want to change the base?

[Woo POS][Coupons] Coupons search #14101

Conversation

samiuelson commented May 22, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Coupons Search in Woo POS

Description

Steps to reproduce

Testing information

The tests that have been performed

Images/gif

Uh oh!

dangermattic commented May 22, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

wpmobilebot commented May 22, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

wpmobilebot commented May 23, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Uh oh!

Copilot AI May 23, 2025

Choose a reason for hiding this comment

Uh oh!

samiuelson May 23, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Copilot AI May 23, 2025

Choose a reason for hiding this comment

Uh oh!

samiuelson May 23, 2025

Choose a reason for hiding this comment

Uh oh!

samiuelson May 23, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Uh oh!

Uh oh!

samiuelson commented May 22, 2025 •

edited

Loading

dangermattic commented May 22, 2025 •

edited

Loading

wpmobilebot commented May 22, 2025 •

edited

Loading

wpmobilebot commented May 23, 2025 •

edited

Loading

samiuelson May 23, 2025 •

edited

Loading

samiuelson May 23, 2025 •

edited

Loading