[Bug] Missing toolbar in EditVariationAttributesFragment in tablet layout #14097
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samiuelson
added
the
feature: variation details
samiuelson
added
type: bug
samiuelson
changed the title
📲 You can test the changes from this Pull Request in WooCommerce-Wear Android by scanning the QR code below to install the corresponding build.
|
|
📲 You can test the changes from this Pull Request in WooCommerce Android by scanning the QR code below to install the corresponding build.
|
kidinov
reviewed
May 21, 2025
| @@ -77,6 +82,15 @@ class EditVariationAttributesFragment : | |||
|
|
|||
| override fun getFragmentTitle() = getString(R.string.product_attributes) | |||
|
|
|||
| private fun setupToolbar() { | |||
There was a problem hiding this comment.
I see that other fragments use setupTabletSecondPaneToolbar extension. Should we do the same?
kidinov
approved these changes
May 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add toolbar to EditVariationAttributesFragment
WOOMOB-481
Description
This PR adds a toolbar to
EditVariationAttributesFragmentthat was missing in the dual-pane layout (e.g. on tablet).Steps to reproduce
On tablet device:
Testing information
Verify that the toolbar is shown both in dual pane and single pane layout.
The tests that have been performed
Above.
Images/gif
RELEASE-NOTES.txtif necessary. Use the "[Internal]" label for non-user-facing changes.