Throw more specific exceptions in JsonPatch::import()
#1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
outdooracorn
commented
Oct 17, 2022
outdooracorn
commented
- InvalidOperationException
- MissingFieldException
- InvalidOperationException - MissingFieldException
Lines Of Code
|
Silvan-WMDE
force-pushed
the
improve-invalid-patch-exceptions
branch
from
984cdc6 to
baa943e
Compare
* rename Invalid... -> Unknown... * make PHP 5.6 compatible * create message inside Exceptions
Silvan-WMDE
force-pushed
the
improve-invalid-patch-exceptions
branch
from
baa943e to
d9a22ad
Compare
jakobw
approved these changes
Oct 17, 2022
jakobw
pushed a commit
that referenced
this pull request
Oct 21, 2022
- UnknownOperationException - MissingFieldException Co-authored-by: sihe <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.