-
-
Notifications
You must be signed in to change notification settings - Fork 9.1k
feat(uglify): move uglify to external plugin from webpack-contrib #5028
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
webpack-sources dependency in uglifyjs plugin need to be updated |
Thanks I'll grab and leave this open and update. |
Will this supersede #5010 ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe add a deprecation note if used through webpack itself.
I'll get to this today |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yarn.lock file need to be updated when plugin was updated
…ck-sources so tests pass
@TheLarkInn Thanks for your update. I labeled the Pull Request so reviewers will review it again. @sokra Please review the new changes. |
Thank you for your pull request! The most important CI builds succeeded, we’ll review the pull request soon. |
Thanks |
What kind of change does this PR introduce?
Refactoring
Did you add tests for your changes?
N/A
If relevant, link to documentation update:
Summary
This PR removes uglifyjs as a direct dependency and removes the internal uglifyjsplugin reference and points it to uglifyjs-webpack-plugin
This allows a bit more freedom to work, change, (or remove later) the uglifyjs-webpack-plugin in a much faster pace (in the case something downstream is breaking).
Does this PR introduce a breaking change?
No
Other information
N/A