Skip to content

feat(uglify): move uglify to external plugin from webpack-contrib #5028

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 19, 2017

Conversation

TheLarkInn
Copy link
Member

What kind of change does this PR introduce?
Refactoring

Did you add tests for your changes?
N/A

If relevant, link to documentation update:

Summary
This PR removes uglifyjs as a direct dependency and removes the internal uglifyjsplugin reference and points it to uglifyjs-webpack-plugin

This allows a bit more freedom to work, change, (or remove later) the uglifyjs-webpack-plugin in a much faster pace (in the case something downstream is breaking).

Does this PR introduce a breaking change?
No

Other information
N/A

@sokra
Copy link
Member

sokra commented Jun 7, 2017

webpack-sources dependency in uglifyjs plugin need to be updated

@TheLarkInn
Copy link
Member Author

Thanks I'll grab and leave this open and update.

@michael-ciniawsky
Copy link
Member

Will this supersede #5010 ? UgilfyJSPlugin is still coupled to core here to some point, I additionally removed optimize-minimize in #5010, which might b a bit harsh tbh, but the reason is that neither this.minimize (Loader API [deprecated]) nor UgilfyJSPlugin should have special meaning anymore as I understood :)

Copy link
Contributor

@bebraw bebraw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe add a deprecation note if used through webpack itself.

@TheLarkInn
Copy link
Member Author

I'll get to this today

@TheLarkInn TheLarkInn closed this Jun 13, 2017
@TheLarkInn TheLarkInn reopened this Jun 13, 2017
Copy link
Member

@sokra sokra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yarn.lock file need to be updated when plugin was updated

@webpack-bot
Copy link
Contributor

@TheLarkInn Thanks for your update.

I labeled the Pull Request so reviewers will review it again.

@sokra Please review the new changes.

@webpack-bot
Copy link
Contributor

Thank you for your pull request! The most important CI builds succeeded, we’ll review the pull request soon.

@sokra sokra merged commit 9feda63 into master Jun 19, 2017
@sokra sokra deleted the feature/externalize_uglify_plugin branch June 19, 2017 15:04
@sokra
Copy link
Member

sokra commented Jun 19, 2017

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants