Fixed 404 fail resource in plugins page #844
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removed section variable from renderer.image in markdown.js because it will fail to load resource ( img, svg, mp4 ) https://webpack.js.org/plugins/npm-install-webpack-plugin https://webpack.js.org/plugins/uglifyjs-webpack-plugin/
|
@simon04 review |
|
@bebraw can we drop the If yes: the line |
|
@simon04 Yeah, most likely. At least the link integrity check passes so it should be fine. I would still check locally to be sure, though. |
|
@bebraw checked localy everything looks good without |
|
Ok. 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed
sectionvariable fromrenderer.imagein file markdown.js because it will fail to load resource ( jpg, gif, svg, mp4 )url with failed resources can be found here.
https://webpack.js.org/plugins/npm-install-webpack-plugin
https://webpack.js.org/plugins/uglifyjs-webpack-plugin/
Actual Behavior in pages