Skip to content

修改文件名 #1371

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

修改文件名 #1371

wants to merge 1 commit into from

Conversation

189
Copy link

@189 189 commented Jul 5, 2017

  1. Read and sign the CLA. This needs to be done only once. PRs that haven't signed it won't be accepted.
  2. Make sure your PR complies with the writer's guide.
  3. Read through the PR diff carefully as sometimes this can reveal issues. The work will be reviewed, but this can save some effort.
  4. Remove these instructions from your PR as they are for your eyes only.

@jsf-clabot
Copy link

jsf-clabot commented Jul 5, 2017

CLA assistant check
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.

@skipjack
Copy link
Collaborator

skipjack commented Jul 5, 2017

@189 thanks for this but I think we'd actually prefer to leave that filename as is because it stays consistent with the rest of the guides (which we're currently in the process of reviewing and cleaning up -- #1258). The output library will still be named properly with the configuration used:

image

Also, and this is more of a sidenote, none of the current maintainers speak Chinese so if you know english it would be much appreciated if you could translate titles/descriptions (e.g. "修改文件名" => "Modify the file name").

@skipjack skipjack closed this Jul 5, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants