-
-
Notifications
You must be signed in to change notification settings - Fork 3.3k
Config - Elaborate on Source Map Options #273
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Note that there are a some open questions about source maps for us also, which is why it's hard to write these docs. With webpack/webpack#3165 we hope to get more insights. |
Thanks for writing up your thoughts on the documentation for What is the current behavior? Currently the documentation for devtool configuration is unclear to me, at least for the speed section. It seems like plusses mean that it runs faster. But maybe it means it takes more time? What does What is the expected behavior? It seems like one or more of the following would help:
Crazy idea:
Thanks, and hope this helps make the documentation better or give some ideas on where I got confused. |
@bebraw : I've been working with source maps quite a bit lately so I'd happy to try a documentation update on this. I do UX design and think @panozzaj 's idea of comparison via data visualization could be a big plus. Sometimes this is as easy as a change in iconography (instead of + or minus). Other times it's reconsidering if something is better expressed as text or via a visualization. I'd be happy to contribute on this. If that's agreeable, how would you like to track? e.g. PR from a fork or direct assignment? I'm new to this project so I'm not familiar with the workflow yet. |
@ecarlisle Awesome to hear. Please PR. Easier to discuss there. 👍 |
Maybe, along with some of the other things discussed, we can link to bits of @simon04's example from webpack/webpack#4698? Would be great to get a solid solution in place for source-mapping docs as it seems there are a lot of open tickets here that relate to it in one way or another. |
@ecarlisle are you still interested in submitting a PR?
A PR from a fork would be great to start. However, if we see that you're contributing often, we may add you as a contributor so you can clone and push branches on the main repo. Re workflow, it's pretty straightforward, just use |
I'm sorry, I fell off the planet for a bit. I'm back now and happy to follow-up. Should we re-open this issue or add new? Thanks! |
@ecarlisle no worries. It's still open btw so let's just continue here. If you would be willing to dig into this that'd be great. I have #1303 open now that fixes some other minor issues with the In doing that PR, I'm starting to think that maybe there's a slightly better way to lay out the documentation (and maybe even in how to configure the option itself). For example, To go along with that, while I know it would be a breaking change, maybe defining module.exports = {
devtool: {
cheap: true,
module: false,
type: 'eval'
},
// ...
} Anyway, I think a little more discussion and some planning may go a long way. |
Elaborate on the `devtool` options and explain in more detail how each one affects the output source mapping and compilation speed. fixes #273 fixes webpack/webpack#2725 fixes webpack/webpack#4936 fixes webpack/webpack#2766 fixes webpack/webpack#2145 fixes webpack/webpack#1689
While browsing webpack's
devtool
section, I found this stub:I agree 100%. For general users, most of them only know sourcemap is a mapping between transpiled and un-transpiled code, and allows them to debug in un-transpiled code.
I come to this section with one question:
Which one should I use?
Which boils down to:
However, I walked away with both questions unanswered, while having more questions:
Also, I was seeing people using
webpack.SourceMapDevToolPlugin()
in webpack 2.0. How does that relate to this setting? Which one should I use?I hope webpack team can keep these questions in mind while reworking on the doc.
The text was updated successfully, but these errors were encountered: