Update connect-history-api-fallback to enable disableDotRule use #638
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, `webpack-dev-server` is requiring `connect-history-api-fallback@^1.2.0` which might resolve to `1.2.0` on current installs. This version doesn't yet allow for the `disableDotRule` option enabled in bripkens/connect-history-api-fallback@ee86111. Using the following in the Webpack Dev Server config works when `[email protected]` is installed: ``` historyApiFallback: { disableDotRule: true, }, ```
This was referenced Oct 5, 2016
|
Cheers! |
|
Thanks for your PR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
examples/(for features)(example already present in https://github.com/webpack/webpack-dev-server/blob/master/examples/history-api-fallback/webpack.config.js)
What kind of change does this PR introduce?
What is the current behavior? (You can also link to an open issue here)
Currently,
webpack-dev-serveris requiringconnect-history-api-fallback@^1.2.0which might resolve to1.2.0on existing installs.This version doesn't yet allow for the
disableDotRuleoption enabled in bripkens/connect-history-api-fallback@ee86111.Using the following in the Webpack Dev Server config works only when
[email protected]is installed:What is the new behavior?
Package always requires
connect-history-api-fallbackat least1.3.0.Does this PR introduce a breaking change?
Other information: