HMR plugin insertion for hot option and inline entry insertion in Server #1738

knagaitsev · 2019-03-23T18:02:32Z

For Bugs and Features; did you add new tests?

Yes, added Hot.test.js to test addition of the HMR plugin using the Server API, added new test in Entry.test.js to check that it prevents duplicate entries on successive calls.

Motivation / Use-Case

Fixes: #1703

It uses the compiler provided to the server to add inline entries (if they don't exist already) and to apply the HMR plugin to the compiler when the hot option is provided.

Edit: also relates to #616. I think it is impossible to avoid mutating the webpack config for this problem. It might be nice to add a feature where you can pass the webpack config into the Server, and then the Server itself creates the compiler.

Breaking Changes

None

Additional Info

It uses some slightly internal compiler functionality like compiler.options. I think it is all safe to use though.

codecov · 2019-03-23T19:36:15Z

Codecov Report

Merging #1738 into master will increase coverage by 0.71%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #1738      +/-   ##
==========================================
+ Coverage   86.13%   86.85%   +0.71%     
==========================================
  Files           8        9       +1     
  Lines         541      578      +37     
  Branches      162      170       +8     
==========================================
+ Hits          466      502      +36     
- Misses         62       63       +1     
  Partials       13       13

Impacted Files	Coverage Δ
lib/Server.js	`82.12% <100%> (-0.17%)`	⬇️
lib/utils/updateCompiler.js	`100% <100%> (ø)`
lib/utils/addEntries.js	`100% <100%> (ø)`	⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a827a65...6fb88a8. Read the comment docs.

…g to next puppeteer test

knagaitsev · 2019-03-23T21:37:23Z

Hmm I can't figure out why it's failing on OSX in Travis CI. Seems to be something to do with chromium writing files as a result of my new Hot tests.

hiroppy · 2019-03-24T11:11:05Z

lib/utils/addEntries.js

+      // make sure that we do not add duplicates.
+      const entriesClone = entries.slice(0);
+      [].concat(entry).forEach((newEntry) => {
+        if (entriesClone.indexOf(newEntry) === -1) {


nit

- if (entriesClone.indexOf(newEntry) === -1) { + if (!entriesClone.includes(newEntry)) {

hiroppy · 2019-03-24T11:15:06Z

Sorry, but I will check again later as I don't have enough time to check this pr. (a little busy)

hiroppy · 2019-03-24T11:16:30Z

libuv is occurring errors on CI.

Assertion failed: (0), function uv__finish_close, file ../deps/uv/src/unix/core.c, line 280.
/Users/travis/.travis/functions: line 104:  3332 Abort trap: 6           npm run $JOB_PART

…e jest could be detecting open handles

knagaitsev · 2019-03-25T04:02:00Z

Not sure how to solve the libuv CI problem, any suggestions? I was changing around various other tests because I suspect what I did is making two changes in behavior with existing tests:

The inline script was not actually inserted by default until now when using Server API.
Adding the inline script makes first compilations take longer than usual because I have to call the entry hook late in the compilation process.

I can go back later and squash these random commits if you want.

Edit: I thought that adding watchOptions: { poll: true } in the place before failure might solve the problem as it seems to have done here: e1f0162

alexander-akait · 2019-03-25T10:14:53Z

lib/Server.js

+          }
+        });
+      }
+    }


I think better create helper/util for this and move this code from Server

@evilebottnawi moved to utils/updateCompiler.js

…it for compilation and not use inline

alexander-akait

Looks great /cc @hiroppy

hiroppy

thanks!

anchengjian · 2019-04-09T09:48:27Z

It changed the order of my entries.

{
  entry: {
    index: ['src/polyfill.js', '(webpack)-dev-server/client?http://0.0.0.0:8081', '(webpack)/hot/only-dev-server.js', './index.tsx']
  }
}

My environment requires Polyfill to be run first, But after updateCompiler, my entries is

{
  entry: {
    index: ['(webpack)-dev-server/client?http://0.0.0.0:8081', '(webpack)/hot/only-dev-server.js', 'src/polyfill.js', './index.tsx']
  }
}

@Loonride @hiroppy @evilebottnawi

Ivaylo-Lafchiev · 2019-04-25T16:18:12Z

I believe this PR has broken our use of the dev-server. When trying to view the site we now get the following error, which prevents the site from loading:

sockjs.js:678 Uncaught SyntaxError: The URL 'localhost.[company].com:20000:20000/sockjs-node' is invalid
    at new SockJS (sockjs.js:678)
    at initSocket (socket.js:9)
    at Object.eval (VM63 client:253)
    at eval (VM63 client:299)
    at Object.../node_modules/webpack-dev-server/client/index.js?localhost.[company].com:20000/ (index-webpack.js:1295)
    at __webpack_require__ (index-webpack.js:724)
    at fn (index-webpack.js:101)
    at eval (client:3)
    at Object.0 (index-webpack.js:4084)
    at __webpack_require__ (index-webpack.js:724)

I believe this issue stems from the HMR entries that have been added, however I'm not entirely sure why the port is duplicated in that URL.

This error doesn't exist in [email protected].
Tested across Node10/Npm 6, Win 7/10 and several permutations of Webpack 4/webpack-dev-server versions.

devServerConfig looks something like this:

        publicPath: '/',
        contentBase: path.join(buildConfig.config.destDir, 'distro'),
        port: 20000,
        host: 'localhost.[company].com',
        hot: true,
        historyApiFallback: true,
        inline: true,
        quiet: false,
        noInfo: false,
        disableHostCheck: true,
        open: true,

Has anyone faced a similar issue or have any idea what the problem might be?

alexander-akait · 2019-04-25T16:19:44Z

localhost.[company].com is invalid url so it can't be parsed normally

Ivaylo-Lafchiev · 2019-04-25T16:22:43Z

localhost.[company].com is invalid url so it can't be parsed normally

apologies, [company] is just me redacting the url. The real URL does not contain brackets.

The non-redacted URL worked fine before 3.3.0 as explained before.

alexander-akait · 2019-04-25T16:27:15Z

Please open new issue with reproducible test repo

HMR plugin insertion and inline entry insertion in server

e03944a

knagaitsev requested review from alexander-akait and hiroppy as code owners March 23, 2019 18:02

changed tests with puppeteer slightly

18f0bc6

make sure that page.goto is done before closing browser and proceedin…

2babccf

…g to next puppeteer test

hiroppy reviewed Mar 24, 2019

View reviewed changes

knagaitsev added 8 commits March 24, 2019 14:26

better test suite for hot and inline, removed hot puppeteer tests

a96e4f4

added inline tests

1575ec7

set polling to true for test environment

5382299

attempt to pass CI with https test changes

241831a

disabled inline for util test

af8741b

reverted some pointless https changes, tried changing some tests wher…

d674ee6

…e jest could be detecting open handles

added non inline for https tests

f5e46a0

switched back to original https changes

41ecdc1

alexander-akait reviewed Mar 25, 2019

View reviewed changes

knagaitsev added 2 commits March 25, 2019 11:21

moved compiler updates to helper file, extreme forcing of tests to wa…

b6dda6f

…it for compilation and not use inline

removed changes in tests out of the scope of this PR

6fb88a8

alexander-akait approved these changes Mar 26, 2019

View reviewed changes

hiroppy approved these changes Mar 27, 2019

View reviewed changes

hiroppy merged commit 1911c37 into webpack:master Mar 27, 2019

cvle mentioned this pull request May 7, 2019

v3.3.0 is breaking create-react-app's custom webpackHotDevClient #1851

Closed

lbogdan mentioned this pull request Jun 21, 2019

Build improvements codesandbox/codesandbox-client#2076

Merged

knagaitsev added gsoc Google Summer of Code scope: cli labels Aug 13, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

HMR plugin insertion for hot option and inline entry insertion in Server #1738

HMR plugin insertion for hot option and inline entry insertion in Server #1738

knagaitsev commented Mar 23, 2019 •

edited

Loading

codecov bot commented Mar 23, 2019 •

edited

Loading

knagaitsev commented Mar 23, 2019 •

edited

Loading

hiroppy Mar 24, 2019

hiroppy commented Mar 24, 2019

hiroppy commented Mar 24, 2019

knagaitsev commented Mar 25, 2019 •

edited

Loading

alexander-akait Mar 25, 2019

knagaitsev Mar 25, 2019

alexander-akait left a comment

hiroppy left a comment

anchengjian commented Apr 9, 2019

Ivaylo-Lafchiev commented Apr 25, 2019

alexander-akait commented Apr 25, 2019

Ivaylo-Lafchiev commented Apr 25, 2019 •

edited

Loading

alexander-akait commented Apr 25, 2019

HMR plugin insertion for hot option and inline entry insertion in Server #1738

HMR plugin insertion for hot option and inline entry insertion in Server #1738

Conversation

knagaitsev commented Mar 23, 2019 • edited Loading

For Bugs and Features; did you add new tests?

Motivation / Use-Case

Breaking Changes

Additional Info

codecov bot commented Mar 23, 2019 • edited Loading

Codecov Report

knagaitsev commented Mar 23, 2019 • edited Loading

hiroppy Mar 24, 2019

Choose a reason for hiding this comment

hiroppy commented Mar 24, 2019

hiroppy commented Mar 24, 2019

knagaitsev commented Mar 25, 2019 • edited Loading

alexander-akait Mar 25, 2019

Choose a reason for hiding this comment

knagaitsev Mar 25, 2019

Choose a reason for hiding this comment

alexander-akait left a comment

Choose a reason for hiding this comment

hiroppy left a comment

Choose a reason for hiding this comment

anchengjian commented Apr 9, 2019

Ivaylo-Lafchiev commented Apr 25, 2019

alexander-akait commented Apr 25, 2019

Ivaylo-Lafchiev commented Apr 25, 2019 • edited Loading

alexander-akait commented Apr 25, 2019

knagaitsev commented Mar 23, 2019 •

edited

Loading

codecov bot commented Mar 23, 2019 •

edited

Loading

knagaitsev commented Mar 23, 2019 •

edited

Loading

knagaitsev commented Mar 25, 2019 •

edited

Loading

Ivaylo-Lafchiev commented Apr 25, 2019 •

edited

Loading