test: add && backport tests from webpack core #56

hulkish · 2017-06-24T23:37:02Z

Closes #1. This is a port of the existing UglifyJsPlugin tests.

I've converted them to jest format and also added a snapshot test. I only added one snapshot test for now.

codecov · 2017-06-24T23:39:35Z

Codecov Report

❗ No coverage uploaded for pull request base (master@0f58cd0). Click here to learn what that means.
The diff coverage is 100%.

@@            Coverage Diff            @@
##             master      #56   +/-   ##
=========================================
  Coverage          ?   96.95%           
=========================================
  Files             ?        2           
  Lines             ?      164           
  Branches          ?       49           
=========================================
  Hits              ?      159           
  Misses            ?        5           
  Partials          ?        0

Impacted Files	Coverage Δ
__tests__/helpers.js	`100% <100%> (ø)`

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0f58cd0...735bf1d. Read the comment docs.

michael-ciniawsky

Thx :) so far

michael-ciniawsky · 2017-06-25T16:58:25Z

__tests__/helpers.js

+const MemoryFileSystem = require("memory-fs");
+const webpack = require("webpack");
+
+exports.PluginEnvironment = class PluginEnvironment {


What is this for ? 🙃

from here

The memory-fs is being used to run a webpack compile without needing to emit files for the test.

👍 Can we make this more generic and could you elaborate a bit more in detail about it, I would like to write docs about it then, for the webpack-defaults test boilerplate

ExpectedPlugin TestPlugin JestPlugin?

Would it also be possible to get the MemoryFS output 'bundle' and snapshot test it?

test('${name}', () => { compiler(fixture, config) .then((result) => { result.stats result.output // MemoryFS Instance as `bundle.js` expect(result.output).toMatchSnapshot() }) .catch((err) => err) })

Yes, and that's probably better anyway. I'll add that in.

How does result.output look like in (terms of noise), could you post it here when ready ? 😛
If we agree on 'extending' a base config we could evetually add CommonChunksPluginto the base to split the webpack runtime by default

[ new CommonChunksPlugin({ name: [ 'runtime', `${fixture}` ], minChunks: Infinity }) ].concat(config.plugins || [])

webpackJsonp([`${fixture}`],{...bundle}

michael-ciniawsky · 2017-06-25T16:59:42Z

codecov.yml

@@ -0,0 +1,17 @@
+codecov:


We may need this in webpack-defaults instead

wouldn't webpack-defaults just create this file here anyway? Or, do u mean it also needs to be added there?

yep, if we need codecov.yml for coverage to work correctly, we should add it to webpack-defaults aswell to keep repos in sync

michael-ciniawsky · 2017-06-25T17:01:06Z

package.json

-    ],
-    "moduleDirectories": [
-      "node_modules"
+	  "coverageDirectory": "./coverage/",


Are most of these not defaults anyways? Also the question if we should add this to webpack-defaults then

I added coverageDirectory to try and get the codecov ci check to succeed. Right now my best guess is that it's only not succeeding because it compares the codecov to master branch - which currently has no tests. Please advise.

michael-ciniawsky · 2017-06-25T17:07:52Z

__tests__/helpers.js

+};
+
+
+exports.runCompiler = function runCompiler(compiler) {


Why not function compile (fixture, config) {} [Discuss], so

import { compile } from './helpers/webpack.js' import UgilfyJSPlugin from '..' test('${name}', () => { const config = { plugins: [ new UgilfyJSPlugin() ] } compile(`${fixture}`, config).then((result) => { // ... }) })

Well, I'm ok with either direction. I hadn't added many snapshots tests yet - but I built this with the idea of making many in mind and thought it would be useful.

This is enterily open for discussion and maybe out of scope of this PR, the direction is fine and changing it in a following PR is totally ok

michael-ciniawsky · 2017-06-25T17:14:39Z

__tests__/UglifyJsPlugin.test.js

@@ -0,0 +1,824 @@
+"use strict";


Sure, but can you clarify? Do u mean put snapshot tests in diff file? Or have the snapshots themselves be separated?

The __snapshots__ directory is just in there as a 'where are we' orientation point, jest will create a separate snapshot for each ${name}.test.js in __snapshots__. The important part is to split test into logical groups, so particular parts can be tested more independently

You could look at webpack-cli to see how we layered our tests :)

michael-ciniawsky · 2017-06-25T17:15:35Z

package.json

    "babel-plugin-syntax-object-rest-spread": "^6.13.0",
    "babel-plugin-transform-object-rest-spread": "^6.20.2",
    "babel-preset-es2015": "^6.18.0",
    "eslint": "^3.13.1",
    "eslint-config-airbnb": "^14.0.0",
    "eslint-plugin-import": "^2.2.0",
+    "eslint-plugin-jest": "^20.0.3",


Needed ? Also needs to be in snyc with webpack-defaults then :)

I don't fully know if this is needed, as most of these are done during dev and caught up during PR reviews/submits:

One issue I can into is that jest needs to be a global. I can remove this plugin and just allow jest to be a global, I suppose.

Update: Actually, I just checked and there's more than just jest that needs to be global. For example: expect/test/it etc. IF you know another way that removes the need for this plugin, let me know.

I suppose turning on env.jasmine = true might solve this... but might not exactly line up with jest.

Also, this seems related - lemme know how we wanna go about this.

kk I can't really say tbh, bc I don't use it myself and as a StandardJS user I never really dealt with ESLint aswell :), if ESLint complains it needs t be solved either in eslint-config-webpack or via a PR adding this plugin to webpack-defaultsin the long-term

evenstensberg · 2017-06-25T17:51:10Z

package.json

-    ],
-    "moduleDirectories": [
-      "node_modules"
+	  "coverageDirectory": "./coverage/",


coverageDirectory defaults to coverage

hulkish · 2017-06-27T03:19:52Z

@michael-ciniawsky better?

alexander-akait

Excellent!

michael-ciniawsky

Thx 👍

michael-ciniawsky · 2017-06-27T17:18:20Z

__tests__/empty-options.snapshot.test.js

+const createCompiler = require("./helpers").createCompiler;
+const compile = require("./helpers").compile;
+
+describe("snapshotss", () => {


snapshotss => snapshots

hulkish · 2017-06-27T17:47:20Z

also added webpack-contrib/webpack-defaults#77 for codecov.yml

michael-ciniawsky · 2017-06-27T18:05:44Z

travis.yml needs an update for node

node_js:
- - "4"
- - "5"
- - "6"
+ - node (Current)
+ - 6 (LTS)
+ - 4 (Maintenance)

invalid-options.test.js is failing due to path mismatches in the Error StackTrace, the individual part could normally be replaced with a regex .*\/... but this one is hairy to substitute 😛

michael-ciniawsky · 2017-06-28T00:24:43Z

__tests__/invalid-options.test.js

@@ -15,8 +16,11 @@ describe("when applied with invalid options", () => {
 		}).apply(compiler);

 		return compile(compiler).then((stats) => {
-			expect(stats.compilation.warnings).toMatchSnapshot("warnings");
-			expect(stats.compilation.errors).toMatchSnapshot("errors");
+			const errors = stats.compilation.errors.map(cleanErrorStack);


hulkish · 2017-06-28T00:54:35Z

@michael-ciniawsky interesting... it fails in ci on node 4 only: https://travis-ci.org/webpack-contrib/uglifyjs-webpack-plugin/jobs/247753398#L242

maybe i remove stack and only render the error message? since node 4 captures error stack differently?

added eslint-plugin-jest for tests, upgraded jest, babel-jest & webpack dev deps cleanup, corrected snapshot test fixed linting errors added eslintignore for test stubs corrected eslintignore paths added codecov config fixing codecov corrected jest test/src/coverage paths removed coverageDirectory: './coverage/' from jest config since it's default separated snapshot tests made createCompiler options replaceable, improved default options test separated tests by logic into separate test files improved snapshot tests cleaned up stacktraces in snapshot output, to allow snapshots to not fail just because paths change in error stack fix typo cleaned up test compilation error stacks to be more generic more cleanup

michael-ciniawsky · 2017-06-28T19:17:19Z

Can you remove the yarn.lock file please webpack-defaults uses package-lock.json&& npm@5 :)

This reverts commit 46b0788.

hulkish force-pushed the unit-tests branch from bea2b1c to 65fb4d7 Compare June 25, 2017 03:27

michael-ciniawsky changed the title ~~Ported tests from core webpack repo & added tests~~ test: add && backport tests from webpack core Jun 25, 2017

michael-ciniawsky added priority: 2 (urgent) pr_action: Review semver: Patch type: CI labels Jun 25, 2017

michael-ciniawsky reviewed Jun 25, 2017

View reviewed changes

michael-ciniawsky requested review from bebraw, alexander-akait and joshwiens June 25, 2017 17:16

michael-ciniawsky added this to the 0.4.7 milestone Jun 25, 2017

evenstensberg reviewed Jun 25, 2017

View reviewed changes

michael-ciniawsky mentioned this pull request Jun 26, 2017

feat: update to uglify-es #55

Closed

alexander-akait approved these changes Jun 27, 2017

View reviewed changes

michael-ciniawsky approved these changes Jun 27, 2017

View reviewed changes

michael-ciniawsky reviewed Jun 27, 2017

View reviewed changes

hulkish mentioned this pull request Jun 27, 2017

removed uglifyjs-webpack-plugin tests webpack/webpack#5174

Merged

michael-ciniawsky approved these changes Jun 28, 2017

View reviewed changes

hulkish changed the base branch from master to feature-defaults June 28, 2017 03:22

hulkish force-pushed the unit-tests branch from 1a25881 to a643248 Compare June 28, 2017 05:30

hulkish added 2 commits June 28, 2017 01:37

fixed tests & lint errors

145158f

hulkish force-pushed the unit-tests branch from a643248 to 145158f Compare June 28, 2017 06:10

michael-ciniawsky modified the milestones: 1.0.0, 0.4.7 Jun 28, 2017

hulkish added 2 commits June 28, 2017 23:18

removed yarn.lock

40959b7

added package-lock.json

2d4579c

TheLarkInn approved these changes Jun 29, 2017

View reviewed changes

TheLarkInn merged commit 46b0788 into webpack-contrib:feature-defaults Jun 29, 2017

TheLarkInn added a commit that referenced this pull request Jun 29, 2017

Revert "test: add && backport tests from webpack core (#56)"

0039642

This reverts commit 46b0788.

TheLarkInn mentioned this pull request Jun 29, 2017

Revert "test: add && backport tests from webpack core" #58

Merged

hulkish mentioned this pull request Jun 29, 2017

test: add && backport tests from webpack core #62

Merged

michael-ciniawsky mentioned this pull request Jun 29, 2017

Port uglifyjs tests from the main repository #1

Closed

gregquat mentioned this pull request Oct 8, 2017

[v0.4.6] npm install fails because of postinstall script #129

Closed

michael-ciniawsky removed this from the 2.0.0 milestone Oct 29, 2017

This was referenced May 17, 2022

[Snyk] Upgrade webpack-sources from 1.3.0 to 1.4.3 AsherLi0103/uglifyjs-webpack-plugin#3

Open

[Snyk] Upgrade serialize-javascript from 1.7.0 to 1.9.1 AsherLi0103/uglifyjs-webpack-plugin#4

Open

Uh oh!

test: add && backport tests from webpack core #56

test: add && backport tests from webpack core #56

Uh oh!

Conversation

hulkish commented Jun 24, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

codecov bot commented Jun 24, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

michael-ciniawsky left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

hulkish Jun 25, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

michael-ciniawsky Jun 26, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

hulkish Jun 26, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

michael-ciniawsky Jun 26, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

michael-ciniawsky Jun 25, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

hulkish Jun 25, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

michael-ciniawsky Jun 25, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

hulkish commented Jun 27, 2017

Uh oh!

alexander-akait left a comment

Choose a reason for hiding this comment

Uh oh!

hulkish commented Jun 24, 2017 •

edited

Loading

codecov bot commented Jun 24, 2017 •

edited

Loading

hulkish Jun 25, 2017 •

edited

Loading

michael-ciniawsky Jun 26, 2017 •

edited

Loading

hulkish Jun 26, 2017 •

edited

Loading

michael-ciniawsky Jun 26, 2017 •

edited

Loading

michael-ciniawsky Jun 25, 2017 •

edited

Loading

hulkish Jun 25, 2017 •

edited

Loading

michael-ciniawsky Jun 25, 2017 •

edited

Loading

hulkish commented Jun 27, 2017 •

edited

Loading

michael-ciniawsky commented Jun 27, 2017 •

edited

Loading

hulkish commented Jun 28, 2017 •

edited

Loading