add support for NullValue #76
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for PR! But actual implementation for null values affects a bit wider scope than just AST and Parser. See graphql/graphql-js#544 for reference. I can merge this PR as is, but if you wish to contribute other missing pieces as well - that would be great. If not - nevermind, since I plan to work on this further sometime soon, will use your PR as a base then. |
|
Will I mainly needed this related to the other PR I sent to you. Probably won't have time to look into this before you fix it :) |
|
Will merge it when I start the work on importing new features from reference implementation for 8.0. |
|
Support for NullValues is in master now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
graphql/graphql-spec#83
The new version of the spec allows for null values