Add new fields and getter steps for static routing resource timing #1769
Conversation
|
This is still a draft PR for the resource timing changes. Let me make it open to get the previews |
|
@domenic @yoshisatoyanagisawa @sisidovski Could you take a look and see if this change makes sense? Thanks! |
|
The direction looks good to me. I left some comments on the step order and a data structure for queueing. |
|
Let me update the doc a bit more |
|
I think the PR is ready to be reviewed again. PTAL. Thanks! |
| 1. Wait until |queue| is not empty. | ||
| 1. Return the result of [=dequeue=] |queue|. | ||
| 1. Let |result| be the result of [=dequeue=] |queue|. | ||
| 1. Set |timingInfo|'s [=service worker timing info/worker final router source=] be set to |result|'s [=/used route=]. |
There was a problem hiding this comment.
nit please use [=race result/used route=] instead.
| @@ -2557,6 +2565,12 @@ spec: storage; urlPrefix: https://storage.spec.whatwg.org/ | |||
|
|
|||
| Note: Keep this definition in sync with [=fetch a classic worker-imported script=]. | |||
|
|
|||
| A <dfn id="dfn-race-result">race result</dfn> is a [=tuple=] of a [=race result/race response=] and [=race result/used route=]. | |||
There was a problem hiding this comment.
Please update existing [=race response=] to [=/race response=] to avoid confusion between [=/race response=] and [=race result/race response=]. Or, give a different name.
There is bikeshed warning like:
LINE 1103:217: Multiple possible 'dfn' local refs for 'race response'.
Randomly chose one of them; other instances might get a different random choice.
[=race response=]
LINE 3264:46: Multiple possible 'dfn' local refs for 'race response'.
Randomly chose one of them; other instances might get a different random choice.
[=race response=]
LINE 3274:50: Multiple possible 'dfn' local refs for 'race response'.
Randomly chose one of them; other instances might get a different random choice.
[=race response=]
LINE 3322:28: Multiple possible 'dfn' local refs for 'race response'.
Randomly chose one of them; other instances might get a different random choice.
[=race response=]
| @@ -3278,6 +3300,7 @@ spec: storage; urlPrefix: https://storage.spec.whatwg.org/ | |||
|
|
|||
| 1. If |navigationPreloadResponse|'s [=response/type=] is "`error`", reject |preloadResponse| with a `TypeError` and terminate these substeps. | |||
| 1. Associate |preloadResponseObject| with |navigationPreloadResponse|. | |||
| 1. If |timingInfo|'s [=service worker timing info/worker final router source=]is set to {{RouterSourceEnum/"network"}}, Set |timingInfo|'s [=service worker timing info/worker final router source=] be set to {{RouterSourceEnum/"fetch-event"}}. | |||
There was a problem hiding this comment.
Can I ask why this line is written here? If this is for SW static routing API, I thought the final router source is set in L3284.
This PR adds the new fields for the static routing API and the getter steps. This will be later exposed to the resource timing API. It has been discussed in w3c/resource-timing#389.
Preview | Diff