types: add typing support #1717
Conversation
types/vue.d.ts
Outdated
| declare module "vue/types/vue" { | ||
| interface Vue { | ||
| declare module "@vue/runtime-core" { | ||
| interface ComponentCustomProperties { |
There was a problem hiding this comment.
Do we remove store type from instance? We have an issue about this at #994
There was a problem hiding this comment.
Ah didn't see that issue, but yea, it makes sense. Let me remove the declaration from ComponentCustomProperties. We can keep ComponentCustomOptions since it doesn't matter so much right...? (it wouldn't be used by users to check store types anyway).
Do you think it can be applied to Vue 3 as well? Or would it be breaking change...? 🤔
There was a problem hiding this comment.
We can keep ComponentCustomOptions since it doesn't matter so much right...?
Yes, I think so.
Do you think it can be applied to Vue 3 as well?
Do you mean Vuex 3? As it's technically breaking change, we should only apply it for Vuex 4.
There was a problem hiding this comment.
Got ya. I'll also put this to my todo list to add in docs as well. I'll update the PR 👍
There was a problem hiding this comment.
Updated! I've removed the type test where checking this.$store as well.
|
I've added section in README that explains the new typings due to #994 change. |
fix #994
Celebrating Vue Beta 2 release, now we can argument type our
$storecustom property in Vue Component 🎉 This PR adds typing support for Vuex 4.