-
-
Notifications
You must be signed in to change notification settings - Fork 33.7k
test: Add a unit test for "$off event and this event added by $once" #9550
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Files in packages
are automatically generated at build time, please do not include them in the PR. Thanks!
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for contributing. But I'm afraid this part cannot be removed.
After removing these two lines, if user call vm.$off
before the event is triggered, it won't work.
eg.
const fn = () => console.log('foo')
this.$once('foo', fn)
this.$off('foo', fn) // this won't work
Since we don't have unit test to cover this case, if you still willing to contribute, add a unit test for it would be appreciated.
Thanks, I will revert what I change and add a unit test for this. |
ohoh, thanks... Co-Authored-By: Luxiaosong <[email protected]>
What kind of change does this PR introduce? (check at least one)
Does this PR introduce a breaking change? (check one)
If yes, please describe the impact and migration path for existing applications:
The PR fulfills these requirements:
dev
branch for v2.x (or to a previous version branch), not themaster
branchfix #xxx[,#xxx]
, where "xxx" is the issue number)If adding a new feature, the PR's description includes:
Other information: