Skip to content

fix the vue init error from private repository in window OS #565

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Feb 5, 2018
Merged

fix the vue init error from private repository in window OS #565

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
108039e
fix the file name can not include symbol ':'
kospot Aug 18, 2017
ae58d90
fix the windowOS download errror
kospot Aug 18, 2017
9440f5f
Update vue-init
posva Sep 26, 2017
d72a9b9
Merge branch 'master' into master
yyx990803 Feb 5, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion bin/vue-init
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,7 @@ var name = inPlace ? path.relative('../', process.cwd()) : rawName
var to = path.resolve(rawName || '.')
var clone = program.clone || false

var tmp = path.join(home, '.vue-templates', template.replace(/\//g, '-'))
var tmp = path.join(home, '.vue-templates', template.replace(/[\/|:]/g, '-'))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

when do you need to replace the | character?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the | character means or

and is that you planing publish the npm package ?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

using [] will already do an or
I don't get your question, can you rephrase it, please?

if (program.offline) {
console.log(`> Use cached template at ${chalk.yellow(tildify(tmp))}`)
template = tmp
Expand Down
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@
"consolidate": "^0.14.0",
"copy-webpack-plugin": "^4.0.1",
"css-loader": "^0.26.1",
"download-git-repo": "^0.2.1",
"download-git-repo": "^1.0.1",
"express": "^4.14.0",
"extract-text-webpack-plugin": "^2.0.0-rc.3",
"file-loader": "^0.9.0",
Expand Down