-
Notifications
You must be signed in to change notification settings - Fork 264
feat: Add event modifiers #590
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add event modifiers #590
Conversation
@cexbrayat Asking because I don't get why in testing we would do something like
|
I think if we handle what's currently in the code base, that would be a nice start https://github.com/vuejs/vue-test-utils-next/blob/7a43f0756e72b3f10c98ebe0135347f5b53a5023/src/createDomEvent.ts#L7-L28 |
If we don't have any intention of doing this, I'd like to close it. Any update? |
I'll continue this on the coming weekend |
No rush, just determining if it's ongoing work or not. Sounds like it is, happy to leave it open 👍 |
@@ -40,7 +18,7 @@ interface TriggerOptions { | |||
} | |||
|
|||
interface EventParams { | |||
eventType: DomEventName | string | |||
eventType: DomEventName |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why was this also a string?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure 🤔
Oh neat, it's green! Anything specific you think is worth manually testing, or we good to merge? |
I don't think this cause any side effects so we good to merge. Only thing could you resolve that comment about the |
Not sure on that |
Will release sometime in the next few days, see if we can clean up a few other issues first. Thanks for this!! |
linked #551