Skip to content

Intialize io_thread_pool attribute in the beginning. #18331

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 22, 2025

Conversation

rabi
Copy link
Contributor

@rabi rabi commented May 19, 2025

We check for io_thread_pool attribute in shutdown() before it could be initialized and results in AttributeError. Should be intialized to None in the beginning before we create a ThreadPoolExecutor.

FIX #18302

We check for it shutdown() and should be intialized to
None before we create ThreadPoolExecutor.

closes: vllm-project#18302
Signed-off-by: rabi <[email protected]>
Copy link

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

@mergify mergify bot added the v1 label May 19, 2025
Copy link
Contributor

@chaunceyjiang chaunceyjiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks~

@rabi
Copy link
Contributor Author

rabi commented May 21, 2025

/retest

@rabi
Copy link
Contributor Author

rabi commented May 21, 2025

@comaniac @WoosukKwon can you have a look please? Looks like the issue was introduced in #14219

Copy link
Collaborator

@comaniac comaniac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for catching

@comaniac comaniac added the ready ONLY add when PR is ready to merge/full CI is needed label May 21, 2025
@vllm-bot vllm-bot merged commit acb54ca into vllm-project:main May 22, 2025
69 of 73 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready ONLY add when PR is ready to merge/full CI is needed v1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: AttributeError: 'MultiprocExecutor' object has no attribute 'io_thread_pool'
4 participants