-
-
Notifications
You must be signed in to change notification settings - Fork 7.6k
[BugFix][AMD] Compatible patch for AITER lib after 04/20 #17912
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BugFix][AMD] Compatible patch for AITER lib after 04/20 #17912
Conversation
Signed-off-by: Qiang Li <[email protected]>
👋 Hi! Thank you for contributing to the vLLM project. 💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels. Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can either: Add 🚀 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall, looks reasonable. Could you paste your test plan/results to the PR description?
@hongxiayang after merging this PR, is there any plan to expedite the checking of existing AITER kernels and fixes for them to work on this new AITER commit? and especially the MLA V1. For documentation purposes: I have quoted the AITER commit mentioned in previous PR (#17864) |
I'm able to run |
Validated the PR, it works. Moreover, at this point in time, the integrated AITER kernels are working with this new AITER commit. The ones that have issues in new AITER commits are:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
…t#17912) Signed-off-by: Qiang Li <[email protected]>
…t#17912) Signed-off-by: Qiang Li <[email protected]> Signed-off-by: Gregory Shtrasberg <[email protected]>
This PR is for AITER API changes introduced by commit 939f741fc37f46694e48c32c7164f49eae2584c4 (merged on 04/20/2025). AITER versions after this commit require this patch to work.