Skip to content

[Feat] Add deprecated=True to CLI args #17426

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
May 6, 2025
Merged

[Feat] Add deprecated=True to CLI args #17426

merged 7 commits into from
May 6, 2025

Conversation

aarnphm
Copy link
Collaborator

@aarnphm aarnphm commented Apr 30, 2025 •
edited by github-actions bot
Loading

This PR adds a small helper to FlexibleArgumentParser to
mark an argument as deprecated, aligning with python 3.13 and above logic

This PR also marks --enable-reasoning as deprecated.

Signed-off-by: Aaron Pham [email protected]

@github-actions GitHub Actions
Copy link

👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

🚀

hmellor
hmellor reviewed Apr 30, 2025
View reviewed changes
Copy link
Member

@hmellor hmellor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could it behave something like https://docs.python.org/3/library/argparse.html#deprecated?

@aarnphm
Copy link
Collaborator Author

aarnphm commented Apr 30, 2025

Oh this is added in 3.13. I will take a look for backport on this then

@chaunceyjiang chaunceyjiang mentioned this pull request Apr 30, 2025
Merged
@hmellor
Copy link
Member

hmellor commented Apr 30, 2025

Ideally it would just be a kwarg we can add to add_argument which triggers a generic warning that this arg is deprecated.

Then somewhere inside the code there will most likely be another warning from @deprecated with the details of the deprecation.

@aarnphm
Copy link
Collaborator Author

aarnphm commented Apr 30, 2025

Hmm, then maybe similar implementation as the builtins behaviour of 3.13 would suffice?

@hmellor
Copy link
Member

hmellor commented Apr 30, 2025

Yeah I was thinking we emulate the 3.13 behaviour because it'll seem "normal" to modern Python users but we won't be able to use the builtin functionality for years!

@aarnphm aarnphm requested a review from hmellor May 2, 2025 21:20
@aarnphm
Copy link
Collaborator Author

aarnphm commented May 2, 2025

@hmellor should be ready for another round of review

@aarnphm aarnphm force-pushed the feat/deprecated-argument branch from 11f0f9e to 38b8d55 Compare May 2, 2025 21:23
@aarnphm
fix: works with subgroup
2439473 
Signed-off-by: Aaron Pham <[email protected]>
@aarnphm aarnphm force-pushed the feat/deprecated-argument branch from 06e5ce8 to 2439473 Compare May 2, 2025 21:36
@aarnphm
--wip--
fa47e7b 
Signed-off-by: Aaron Pham <[email protected]>
hmellor
hmellor reviewed May 2, 2025
View reviewed changes
@aarnphm aarnphm requested a review from hmellor May 4, 2025 00:52
hmellor
hmellor reviewed May 5, 2025
View reviewed changes
Copy link
Member

@hmellor hmellor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall, but you've used some syntax that isn't compatible with Python 3.9

@aarnphm aarnphm requested a review from hmellor May 5, 2025 18:13
@aarnphm aarnphm added this to the v0.9.0 milestone May 5, 2025
hmellor
hmellor approved these changes May 5, 2025
View reviewed changes
Copy link
Member

@hmellor hmellor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for bringing us this feature from the future!

@hmellor hmellor enabled auto-merge (squash) May 5, 2025 18:41
@github-actions github-actions bot added the ready ONLY add when PR is ready to merge/full CI is needed label May 5, 2025
@hmellor hmellor mentioned this pull request May 6, 2025
Merged
@vllm-bot vllm-bot merged commit 175bda6 into vllm-project:main May 6, 2025
70 of 74 checks passed
robertgshaw2-redhat added a commit to neuralmagic/vllm that referenced this pull request May 6, 2025
@robertgshaw2-redhat @s3woz
@bohnstingl @DarkLight1337 @tlrmchlsmth @zou3519 @Xarbirus @LucasWilkinson @hmellor @MengqingCao @mgoin @bigPYJ1151 @heheda12345 @aarnphm @windsonsea @reidliu41 @bythew3i @dtransposed @gshtras @tdoublep
Upstream Sync (#80)
76186b9 
* [Model] Add GraniteMoeHybrid 4.0 model (vllm-project#17497)

Signed-off-by: Thomas Ortner <[email protected]>
Signed-off-by: Stanislaw Wozniak <[email protected]>
Co-authored-by: Thomas Ortner <[email protected]>
Co-authored-by: Cyrus Leung <[email protected]>
Co-authored-by: Tyler Michael Smith <[email protected]>

* [easy] Fix logspam on PiecewiseBackend errors (vllm-project#17138)

Signed-off-by: rzou <[email protected]>

* [Bugfix] Fixed prompt length for random dataset (vllm-project#17408)

Signed-off-by: Mikhail Podvitskii <[email protected]>

* [Doc] Update notes for H2O-VL and Gemma3 (vllm-project#17219)

Signed-off-by: DarkLight1337 <[email protected]>

* [Misc] Fix ScalarType float4 naming  (vllm-project#17690)

Signed-off-by: Lucas Wilkinson <[email protected]>

* Fix `dockerfilegraph` pre-commit hook (vllm-project#17698)

Signed-off-by: Harry Mellor <[email protected]>

* [Bugfix] Fix triton import with local TritonPlaceholder (vllm-project#17446)

Signed-off-by: Mengqing Cao <[email protected]>

* [V1] Enable TPU V1 backend by default (vllm-project#17673)

Signed-off-by: mgoin <[email protected]>

* [V1][PP] Support PP for MultiprocExecutor (vllm-project#14219)

Signed-off-by: jiang1.li <[email protected]>
Signed-off-by: jiang.li <[email protected]>

* [v1] AttentionMetadata for each layer (vllm-project#17394)

Signed-off-by: Chen Zhang <[email protected]>

* [Feat] Add deprecated=True to CLI args (vllm-project#17426)

Signed-off-by: Aaron Pham <[email protected]>

* [Docs] Use gh-file to add links to tool_calling.md (vllm-project#17709)

Signed-off-by: windsonsea <[email protected]>

* [v1] Introduce KVCacheBlocks as interface between Scheduler and KVCacheManager (vllm-project#17479)

Signed-off-by: Chen Zhang <[email protected]>

* [doc] Add RAG Integration example (vllm-project#17692)

Signed-off-by: reidliu41 <[email protected]>
Co-authored-by: reidliu41 <[email protected]>

* [Bugfix] Fix modality limits in vision language example (vllm-project#17721)

Signed-off-by: DarkLight1337 <[email protected]>

* Make right sidebar more readable in "Supported Models" (vllm-project#17723)

Signed-off-by: Harry Mellor <[email protected]>

* [TPU] Increase block size and reset block shapes (vllm-project#16458)

* [Misc] Add Next Edit Prediction (NEP) datasets support in `benchmark_serving.py` (vllm-project#16839)

Signed-off-by: dtransposed <damian@damian-ml-machine.europe-west3-b.c.jetbrains-grazie.internal>
Signed-off-by: dtransposed <>
Co-authored-by: dtransposed <damian@damian-ml-machine.europe-west3-b.c.jetbrains-grazie.internal>

* [Bugfix] Fix for the condition to accept empty encoder inputs for mllama (vllm-project#17732)

Signed-off-by: Gregory Shtrasberg <[email protected]>

* [Kernel] Unified Triton kernel that doesn't distinguish between prefill + decode (vllm-project#16828)

Signed-off-by: Thomas Parnell <[email protected]>
Signed-off-by: Lucas Wilkinson <[email protected]>
Co-authored-by: Lucas Wilkinson <[email protected]>

---------

Signed-off-by: Thomas Ortner <[email protected]>
Signed-off-by: Stanislaw Wozniak <[email protected]>
Signed-off-by: rzou <[email protected]>
Signed-off-by: Mikhail Podvitskii <[email protected]>
Signed-off-by: DarkLight1337 <[email protected]>
Signed-off-by: Lucas Wilkinson <[email protected]>
Signed-off-by: Harry Mellor <[email protected]>
Signed-off-by: Mengqing Cao <[email protected]>
Signed-off-by: mgoin <[email protected]>
Signed-off-by: jiang1.li <[email protected]>
Signed-off-by: jiang.li <[email protected]>
Signed-off-by: Chen Zhang <[email protected]>
Signed-off-by: Aaron Pham <[email protected]>
Signed-off-by: windsonsea <[email protected]>
Signed-off-by: reidliu41 <[email protected]>
Signed-off-by: dtransposed <damian@damian-ml-machine.europe-west3-b.c.jetbrains-grazie.internal>
Signed-off-by: dtransposed <>
Signed-off-by: Gregory Shtrasberg <[email protected]>
Signed-off-by: Thomas Parnell <[email protected]>
Signed-off-by: [email protected] <[email protected]>
Co-authored-by: Stan Wozniak <[email protected]>
Co-authored-by: Thomas Ortner <[email protected]>
Co-authored-by: Cyrus Leung <[email protected]>
Co-authored-by: Tyler Michael Smith <[email protected]>
Co-authored-by: Richard Zou <[email protected]>
Co-authored-by: Mikhail Podvitskii <[email protected]>
Co-authored-by: Cyrus Leung <[email protected]>
Co-authored-by: Lucas Wilkinson <[email protected]>
Co-authored-by: Harry Mellor <[email protected]>
Co-authored-by: Mengqing Cao <[email protected]>
Co-authored-by: Michael Goin <[email protected]>
Co-authored-by: Li, Jiang <[email protected]>
Co-authored-by: Chen Zhang <[email protected]>
Co-authored-by: Aaron Pham <[email protected]>
Co-authored-by: Michael Yao <[email protected]>
Co-authored-by: Reid <[email protected]>
Co-authored-by: reidliu41 <[email protected]>
Co-authored-by: Jevin Jiang <[email protected]>
Co-authored-by: d.transposed <[email protected]>
Co-authored-by: dtransposed <damian@damian-ml-machine.europe-west3-b.c.jetbrains-grazie.internal>
Co-authored-by: Gregory Shtrasberg <[email protected]>
Co-authored-by: Thomas Parnell <[email protected]>
Co-authored-by: Lucas Wilkinson <[email protected]>
@aarnphm aarnphm deleted the feat/deprecated-argument branch May 6, 2025 23:28
@sarckk sarckk mentioned this pull request May 7, 2025
Merged
RichardoMrMu pushed a commit to RichardoMrMu/vllm that referenced this pull request May 12, 2025
@aarnphm
[Feat] Add deprecated=True to CLI args (vllm-project#17426)
f7e6605 
Signed-off-by: Aaron Pham <[email protected]>
Signed-off-by: Mu Huai <[email protected]>
mawong-amd pushed a commit to ROCm/vllm that referenced this pull request May 14, 2025
@aarnphm @mawong-amd
[Feat] Add deprecated=True to CLI args (vllm-project#17426)
a77169d 
Signed-off-by: Aaron Pham <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hmellor hmellor hmellor approved these changes

@DarkLight1337 DarkLight1337 Awaiting requested review from DarkLight1337

Assignees
No one assigned
Labels
ready ONLY add when PR is ready to merge/full CI is needed
Projects
None yet
Milestone
v0.9.0
Development

Successfully merging this pull request may close these issues.
3 participants
@aarnphm @hmellor @vllm-bot