-
-
Notifications
You must be signed in to change notification settings - Fork 7.6k
[Misc] fix collect_env version parse #15267
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
👋 Hi! Thank you for contributing to the vLLM project. 💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels. Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can either: Add 🚀 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we add some unittest?
unittest would be ideal, but it's complicated to test all the cases, e.g. released versions, dev versions, local installed versions, etc. |
Signed-off-by: wangxiyuan <[email protected]>
Fixed merge conflict |
Signed-off-by: wangxiyuan <[email protected]> Signed-off-by: Yang Wang <[email protected]>
Signed-off-by: wangxiyuan <[email protected]> Signed-off-by: dtransposed <damian@damian-ml-machine.europe-west3-b.c.jetbrains-grazie.internal>
Signed-off-by: wangxiyuan <[email protected]> Signed-off-by: Frieda (Jingying) Huang <[email protected]>
Signed-off-by: wangxiyuan <[email protected]> Signed-off-by: Zijing Liu <[email protected]>
Signed-off-by: wangxiyuan <[email protected]>
Signed-off-by: wangxiyuan <[email protected]>
Signed-off-by: wangxiyuan <[email protected]>
Signed-off-by: wangxiyuan <[email protected]>
Signed-off-by: wangxiyuan <[email protected]> Signed-off-by: Agata Dobrzyniewicz <[email protected]>
Signed-off-by: wangxiyuan <[email protected]> Signed-off-by: Mu Huai <[email protected]>
The version parse in
collect_env.py
is not correct. The__version_tuple__
fromsetuptools_scm
is a tuple like(0,8,1)
,(0,8,1,dev86,ge588ac237)
or(0,8,1,dev86,ge588ac237+d20250321)
. The length will never be 4. See: https://setuptools-scm.readthedocs.io/en/stable/usage/ which the length is not limited to 4.We should pares the
__version_tuple__
in a correct way. With this PR, the version will be parsed into some result:setuptools_scm
is not working, the result will beN/A (dev)
0.8.1
0.8.2.dev86+ge588ac237 (git_sha: e588ac237)
0.8.2.dev86+ge588ac237.d20250321 (git sha: e588ac237, date: 20250321)