-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
set tlBaseVersion := "2.13" #4704
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@armanbilge does it mean that we have to bump up Because to me this doc is not very clear about that:
But we didn't introduce breaking changes in v2.13.0 comparing to v2.12.0, or did we? |
Yes, if the minor version changes,
That FAQ entry is for when you do need to make a breaking change. The next one is a little more informative for your question. The tl;dr is that |
Actually, we did :)
Both of these are reasons to bump the minor version, which we do via the base version. In fact, the correct time to bump |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Historically, I've bumped to the next base version immediately after a release (in this case, we would bump straight to 2.14). But I've only done that, because in general we are not very disciplined at bumping when we are supposed to 😅
@armanbilge , hmm... I'm not sure I got this:
I believe if some codebase had been compiling with v2.12.0 then upgraded to v2.13.0, then no source changes should be necessary to keep it compiling with v2.13.0 whatsoever (unless we introduces a bug, but that's a different story). What am I missing here?
I can change it to "2.14" in this PR, if it makes sense. My only concern is then – why cannot we set it to "2.999" then once and until we grow up to the next major release? |
I think we'd better off to merge this one as is now to unblock updates. We can catch up in following PRs. |
Seems required to prevent CI from failing with
(see #4703 (comment))