Fix CI, part 2 #1118
Closed
Fix CI, part 2 #1118
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andersk
reviewed
Aug 25, 2022
| @@ -20,7 +20,7 @@ def find_stub_files(name: str) -> List[str]: | |||
| readme = f.read() | |||
|
|
|||
| dependencies = [ | |||
| "mypy>=0.930", | |||
| "mypy>=0.930,<0.970", # TODO: remove after CI is fixed | |||
There was a problem hiding this comment.
This shouldn’t be necessary for the sake of CI. CI does pip install -r ./requirements.txt, and requirements.txt already includes mypy==0.961 (and also -e .[compatible-mypy] which constrains mypy to <0.970).
There was a problem hiding this comment.
Any ideas how to fix it?
andersk
reviewed
Aug 25, 2022
| @@ -21,7 +21,7 @@ jobs: | |||
| python-version: ${{ matrix.python-version }} | |||
| - name: Install dependencies | |||
| run: | | |||
| pip install -U pip setuptools wheel | |||
| pip install -U pip 'setuptools<64' wheel | |||
There was a problem hiding this comment.
I think the two other copies of this need to be patched too?
This was referenced Aug 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs #1108