Skip to content

Fixed function overloading and combining Options with locals. #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Sep 13, 2016
Merged

Fixed function overloading and combining Options with locals. #4

merged 10 commits into from
Sep 13, 2016

Conversation

MichalLytek
Copy link
Contributor

Fixed PR #3.

@MichalLytek
Copy link
Contributor Author

I still don't know how to git but now at least no merge conflict.

@blakeembrey
Copy link
Member

@19majkel94 For the PR, can you just put the overloads directly below? You don't need to duplicate the comments 😄

On the rebase, you can reset history back to before the change, then pull back from upstream to fix it. Not sure if there's another recommended way.

@blakeembrey blakeembrey merged commit e494165 into typed-typings:master Sep 13, 2016
@MichalLytek
Copy link
Contributor Author

@blakeembrey

For the PR, can you just put the overloads directly below? You don't need to duplicate the comments 😄

I thought that it works but I checked and there was no intelisense comment on overloaded function. And the comments are not duplicated, the second overload don't render with locals.

@MichalLytek
Copy link
Contributor Author

This is how it now shows in VS Code:

2016-09-13 10_03_52-startowa
2016-09-13 10_03_57-startowa

It would be better to rollback to an earlier commit or split this definitions to 4 clean overloads without "?" on params.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants