-
Notifications
You must be signed in to change notification settings - Fork 0
Fixed function overloading and combining Options with locals. #4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The options object is also used as the locals object.
The options object is also used as the locals object.
I still don't know how to git but now at least no merge conflict. |
@19majkel94 For the PR, can you just put the overloads directly below? You don't need to duplicate the comments 😄 On the rebase, you can reset history back to before the change, then pull back from upstream to fix it. Not sure if there's another recommended way. |
I thought that it works but I checked and there was no intelisense comment on overloaded function. And the comments are not duplicated, the second overload don't render with locals. |
Fixed PR #3.